Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Fix error code thrown when the network errors out #5892

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jan 13, 2022

Fixes #5874

The error being thrown when the network timed out was not the correct one to use.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 3c6ac44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yuchenshi yuchenshi assigned sam-gc and unassigned lisajian and yuchenshi Jan 13, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 13, 2022

Size Report 1

Affected Products

  • @firebase/auth/cordova

    TypeBase (88d43ec)Merge (b9b433b)Diff
    browser180 kB180 kB+15 B (+0.0%)
    module180 kB180 kB+15 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (88d43ec)Merge (b9b433b)Diff
    browser163 kB163 kB+15 B (+0.0%)
    esm5212 kB212 kB+15 B (+0.0%)
    main179 kB179 kB+15 B (+0.0%)
    module163 kB163 kB+15 B (+0.0%)
  • @firebase/auth/react-native

    TypeBase (88d43ec)Merge (b9b433b)Diff
    browser163 kB163 kB+15 B (+0.0%)
    module163 kB163 kB+15 B (+0.0%)
  • bundle

    TypeBase (88d43ec)Merge (b9b433b)Diff
    auth (Anonymous)57.0 kB57.0 kB+15 B (+0.0%)
    auth (EmailAndPassword)61.1 kB61.1 kB+15 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)80.8 kB80.8 kB+15 B (+0.0%)
    auth (GooglePopup)80.6 kB80.6 kB+15 B (+0.0%)
    auth (GoogleRedirect)80.8 kB80.8 kB+15 B (+0.0%)
    auth (Phone)67.0 kB67.0 kB+15 B (+0.0%)
  • firebase

    TypeBase (88d43ec)Merge (b9b433b)Diff
    firebase-auth-compat.js123 kB123 kB+15 B (+0.0%)
    firebase-auth.js411 kB411 kB+30 B (+0.0%)
    firebase-compat.js753 kB753 kB+15 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xHvXAwXuwm.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 14, 2022

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.2 kB+15 B (+0.0%)
      size-with-ext-deps42.0 kB42.1 kB+15 B (+0.0%)
    • ActionCodeURL

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.0 kB31.0 kB+15 B (+0.0%)
      size-with-ext-deps43.1 kB43.1 kB+15 B (+0.0%)
    • AuthCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.2 kB+15 B (+0.0%)
      size-with-ext-deps42.1 kB42.1 kB+15 B (+0.0%)
    • AuthErrorCodes

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size34.6 kB34.6 kB+15 B (+0.0%)
      size-with-ext-deps46.5 kB46.5 kB+15 B (+0.0%)
    • EmailAuthCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size32.1 kB32.1 kB+15 B (+0.0%)
      size-with-ext-deps44.0 kB44.0 kB+15 B (+0.0%)
    • EmailAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size33.5 kB33.5 kB+15 B (+0.0%)
      size-with-ext-deps45.6 kB45.7 kB+15 B (+0.0%)
    • FacebookAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.1 kB35.1 kB+15 B (+0.0%)
      size-with-ext-deps47.0 kB47.0 kB+15 B (+0.0%)
    • FactorId

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size29.9 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • GithubAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.1 kB35.1 kB+15 B (+0.0%)
      size-with-ext-deps47.0 kB47.0 kB+15 B (+0.0%)
    • GoogleAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.1 kB35.1 kB+15 B (+0.0%)
      size-with-ext-deps47.0 kB47.0 kB+15 B (+0.0%)
    • OAuthCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size32.2 kB32.2 kB+15 B (+0.0%)
      size-with-ext-deps44.1 kB44.1 kB+15 B (+0.0%)
    • OAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size36.0 kB36.1 kB+15 B (+0.0%)
      size-with-ext-deps47.9 kB47.9 kB+15 B (+0.0%)
    • OperationType

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.9 kB41.9 kB+15 B (+0.0%)
    • PhoneAuthCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size32.2 kB32.2 kB+15 B (+0.0%)
      size-with-ext-deps44.1 kB44.1 kB+15 B (+0.0%)
    • PhoneAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size33.9 kB33.9 kB+15 B (+0.0%)
      size-with-ext-deps45.8 kB45.8 kB+15 B (+0.0%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.9 kB30.9 kB+15 B (+0.0%)
      size-with-ext-deps42.8 kB42.8 kB+15 B (+0.0%)
    • ProviderId

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.1 kB30.1 kB+15 B (+0.0%)
      size-with-ext-deps41.9 kB41.9 kB+15 B (+0.0%)
    • RecaptchaVerifier

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size36.3 kB36.4 kB+15 B (+0.0%)
      size-with-ext-deps48.2 kB48.2 kB+15 B (+0.0%)
    • SAMLAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size36.4 kB36.4 kB+15 B (+0.0%)
      size-with-ext-deps48.2 kB48.3 kB+15 B (+0.0%)
    • SignInMethod

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.1 kB30.1 kB+15 B (+0.0%)
      size-with-ext-deps41.9 kB42.0 kB+15 B (+0.0%)
    • TwitterAuthProvider

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.1 kB35.1 kB+15 B (+0.0%)
      size-with-ext-deps47.0 kB47.0 kB+15 B (+0.0%)
    • applyActionCode

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.2 kB+15 B (+0.0%)
      size-with-ext-deps42.0 kB42.0 kB+15 B (+0.0%)
    • browserLocalPersistence

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size33.3 kB33.3 kB+15 B (+0.0%)
      size-with-ext-deps45.3 kB45.3 kB+15 B (+0.0%)
    • browserPopupRedirectResolver

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size54.2 kB54.3 kB+15 B (+0.0%)
      size-with-ext-deps66.3 kB66.3 kB+15 B (+0.0%)
    • browserSessionPersistence

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size33.3 kB33.3 kB+15 B (+0.0%)
      size-with-ext-deps45.3 kB45.3 kB+15 B (+0.0%)
    • checkActionCode

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.1 kB31.1 kB+15 B (+0.0%)
      size-with-ext-deps43.0 kB43.0 kB+15 B (+0.0%)
    • confirmPasswordReset

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.2 kB+15 B (+0.0%)
      size-with-ext-deps42.1 kB42.1 kB+15 B (+0.0%)
    • connectAuthEmulator

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.7 kB31.7 kB+15 B (+0.0%)
      size-with-ext-deps43.5 kB43.6 kB+15 B (+0.0%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.1 kB31.1 kB+15 B (+0.0%)
      size-with-ext-deps42.9 kB43.0 kB+15 B (+0.0%)
    • debugErrorMap

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size41.0 kB41.0 kB+15 B (+0.0%)
      size-with-ext-deps52.9 kB52.9 kB+15 B (+0.0%)
    • deleteUser

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.4 kB30.4 kB+15 B (+0.0%)
      size-with-ext-deps42.3 kB42.3 kB+15 B (+0.0%)
    • getAdditionalUserInfo

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.3 kB31.3 kB+15 B (+0.0%)
      size-with-ext-deps43.1 kB43.1 kB+15 B (+0.0%)
    • getAuth

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size61.9 kB62.0 kB+15 B (+0.0%)
      size-with-ext-deps74.5 kB74.5 kB+15 B (+0.0%)
    • getIdToken

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.9 kB+15 B (+0.0%)
    • getIdTokenResult

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size29.9 kB29.9 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • getMultiFactorResolver

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size32.7 kB32.7 kB+15 B (+0.0%)
      size-with-ext-deps44.5 kB44.5 kB+15 B (+0.0%)
    • getRedirectResult

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size37.6 kB37.6 kB+15 B (+0.0%)
      size-with-ext-deps49.5 kB49.5 kB+15 B (+0.0%)
    • inMemoryPersistence

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size29.9 kB29.9 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • indexedDBLocalPersistence

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size37.4 kB37.4 kB+15 B (+0.0%)
      size-with-ext-deps49.2 kB49.2 kB+15 B (+0.0%)
    • initializeAuth

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.2 kB+15 B (+0.0%)
      size-with-ext-deps42.4 kB42.4 kB+15 B (+0.0%)
    • isSignInWithEmailLink

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.1 kB31.1 kB+15 B (+0.0%)
      size-with-ext-deps43.2 kB43.2 kB+15 B (+0.0%)
    • linkWithCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.0 kB31.0 kB+15 B (+0.0%)
      size-with-ext-deps42.8 kB42.8 kB+15 B (+0.0%)
    • linkWithPhoneNumber

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size34.6 kB34.7 kB+15 B (+0.0%)
      size-with-ext-deps46.5 kB46.5 kB+15 B (+0.0%)
    • linkWithPopup

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size41.2 kB41.2 kB+15 B (+0.0%)
      size-with-ext-deps53.1 kB53.1 kB+15 B (+0.0%)
    • linkWithRedirect

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size36.4 kB36.4 kB+15 B (+0.0%)
      size-with-ext-deps48.2 kB48.3 kB+15 B (+0.0%)
    • multiFactor

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size32.1 kB32.1 kB+15 B (+0.0%)
      size-with-ext-deps44.0 kB44.0 kB+15 B (+0.0%)
    • onAuthStateChanged

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.9 kB41.9 kB+15 B (+0.0%)
    • onIdTokenChanged

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.9 kB+15 B (+0.0%)
    • parseActionCodeURL

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.1 kB31.1 kB+15 B (+0.0%)
      size-with-ext-deps43.2 kB43.2 kB+15 B (+0.0%)
    • prodErrorMap

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size29.9 kB29.9 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • reauthenticateWithCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.5 kB31.5 kB+15 B (+0.0%)
      size-with-ext-deps43.4 kB43.4 kB+15 B (+0.0%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.2 kB35.2 kB+15 B (+0.0%)
      size-with-ext-deps47.1 kB47.1 kB+15 B (+0.0%)
    • reauthenticateWithPopup

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size41.2 kB41.2 kB+15 B (+0.0%)
      size-with-ext-deps53.1 kB53.1 kB+15 B (+0.0%)
    • reauthenticateWithRedirect

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size36.1 kB36.1 kB+15 B (+0.0%)
      size-with-ext-deps48.0 kB48.0 kB+15 B (+0.0%)
    • reload

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size29.9 kB29.9 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • sendEmailVerification

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.0 kB31.0 kB+15 B (+0.0%)
      size-with-ext-deps42.9 kB42.9 kB+15 B (+0.0%)
    • sendPasswordResetEmail

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.9 kB30.9 kB+15 B (+0.0%)
      size-with-ext-deps42.8 kB42.8 kB+15 B (+0.0%)
    • sendSignInLinkToEmail

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.9 kB30.9 kB+15 B (+0.0%)
      size-with-ext-deps42.8 kB42.8 kB+15 B (+0.0%)
    • setPersistence

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.9 kB+15 B (+0.0%)
    • signInAnonymously

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.2 kB31.2 kB+15 B (+0.0%)
      size-with-ext-deps43.1 kB43.1 kB+15 B (+0.0%)
    • signInWithCredential

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.3 kB31.3 kB+15 B (+0.0%)
      size-with-ext-deps43.2 kB43.2 kB+15 B (+0.0%)
    • signInWithCustomToken

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.1 kB31.1 kB+15 B (+0.0%)
      size-with-ext-deps42.9 kB42.9 kB+15 B (+0.0%)
    • signInWithEmailAndPassword

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.0 kB35.0 kB+15 B (+0.0%)
      size-with-ext-deps47.1 kB47.1 kB+15 B (+0.0%)
    • signInWithEmailLink

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.2 kB35.2 kB+15 B (+0.0%)
      size-with-ext-deps47.3 kB47.3 kB+15 B (+0.0%)
    • signInWithPhoneNumber

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.0 kB35.0 kB+15 B (+0.0%)
      size-with-ext-deps46.9 kB46.9 kB+15 B (+0.0%)
    • signInWithPopup

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size41.2 kB41.2 kB+15 B (+0.0%)
      size-with-ext-deps53.0 kB53.1 kB+15 B (+0.0%)
    • signInWithRedirect

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size35.8 kB35.8 kB+15 B (+0.0%)
      size-with-ext-deps47.7 kB47.7 kB+15 B (+0.0%)
    • signOut

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • unlink

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.5 kB30.5 kB+15 B (+0.0%)
      size-with-ext-deps42.4 kB42.4 kB+15 B (+0.0%)
    • updateCurrentUser

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.9 kB+15 B (+0.0%)
    • updateEmail

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.3 kB+15 B (+0.0%)
      size-with-ext-deps42.1 kB42.1 kB+15 B (+0.0%)
    • updatePassword

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.2 kB30.3 kB+15 B (+0.0%)
      size-with-ext-deps42.1 kB42.1 kB+15 B (+0.0%)
    • updatePhoneNumber

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.7 kB30.7 kB+15 B (+0.0%)
      size-with-ext-deps42.6 kB42.6 kB+15 B (+0.0%)
    • updateProfile

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.4 kB30.5 kB+15 B (+0.0%)
      size-with-ext-deps42.3 kB42.3 kB+15 B (+0.0%)
    • useDeviceLanguage

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size30.0 kB30.0 kB+15 B (+0.1%)
      size-with-ext-deps41.8 kB41.8 kB+15 B (+0.0%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.0 kB31.0 kB+15 B (+0.0%)
      size-with-ext-deps42.9 kB42.9 kB+15 B (+0.0%)
    • verifyPasswordResetCode

      Size

      TypeBase (88d43ec)Merge (d8b9189)Diff
      size31.2 kB31.2 kB+15 B (+0.0%)
      size-with-ext-deps43.1 kB43.1 kB+15 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8pHzNwdX35.html

@sam-gc sam-gc merged commit 922e9ed into master Jan 14, 2022
@sam-gc sam-gc deleted the sam-gc/network-timeout branch January 14, 2022 00:23
@google-oss-bot google-oss-bot mentioned this pull request Jan 20, 2022
@firebase firebase locked and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth persistence sometimes clears the user
4 participants