Skip to content

[Auth] Fix error code thrown when the network errors out #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2022
Merged

[Auth] Fix error code thrown when the network errors out #5892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0787020
Fix error code thrown when the network errors out
sam-gc Jan 13, 2022
3c6ac44
Add changeset
sam-gc Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/moody-ways-learn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/auth": patch
---

Fix error code thrown when the network times out
2 changes: 1 addition & 1 deletion packages/auth/src/api/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ describe('api/_performApiRequest', () => {
request
);
clock.tick(DEFAULT_API_TIMEOUT_MS.get() + 1);
await expect(promise).to.be.rejectedWith(FirebaseError, 'auth/timeout');
await expect(promise).to.be.rejectedWith(FirebaseError, 'auth/network-request-failed');
clock.restore();
});

Expand Down
2 changes: 1 addition & 1 deletion packages/auth/src/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ class NetworkTimeout<T> {
private timer: any | null = null;
readonly promise = new Promise<T>((_, reject) => {
this.timer = setTimeout(() => {
return reject(_createError(this.auth, AuthErrorCode.TIMEOUT));
return reject(_createError(this.auth, AuthErrorCode.NETWORK_REQUEST_FAILED));
}, DEFAULT_API_TIMEOUT_MS.get());
});

Expand Down