[Storage] Cleared timeouts upon pause/resume of uploads #6667

maneesht · 2022-10-08T00:34:07Z

Made sure that timers are cleaned up when in the middle of exponential backoff.

changeset-bot · 2022-10-08T00:34:10Z

🦋 Changeset detected

Latest commit: 3cac155

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/storage	Patch
firebase	Patch
@firebase/storage-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-10-08T00:54:21Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (29d0340) Merge (75779cd) Diff
browser 20.1 kB 20.2 kB +59 B (+0.3%)
esm5 24.7 kB 24.8 kB +59 B (+0.2%)
main 26.0 kB 26.1 kB +59 B (+0.2%)
module 20.1 kB 20.2 kB +59 B (+0.3%)
@firebase/database
Type Base (29d0340) Merge (75779cd) Diff
browser 248 kB 248 kB -62 B (-0.0%)
esm5 276 kB 276 kB -49 B (-0.0%)
main 281 kB 281 kB -54 B (-0.0%)
module 248 kB 248 kB -62 B (-0.0%)
@firebase/firestore
Type Base (29d0340) Merge (75779cd) Diff
browser 266 kB 266 kB -18 B (-0.0%)
main 531 kB 531 kB -76 B (-0.0%)
module 266 kB 266 kB -18 B (-0.0%)
react-native 266 kB 266 kB -18 B (-0.0%)
@firebase/firestore-compat
Type Base (29d0340) Merge (75779cd) Diff
browser 20.5 kB 20.5 kB -1 B (-0.0%)
esm5 27.6 kB 27.6 kB -1 B (-0.0%)
main 20.9 kB 20.9 kB -1 B (-0.0%)
module 20.5 kB 20.5 kB -1 B (-0.0%)
react-native 20.5 kB 20.5 kB -1 B (-0.0%)
@firebase/firestore-lite
Type Base (29d0340) Merge (75779cd) Diff
browser 82.2 kB 82.2 kB -18 B (-0.0%)
main 139 kB 139 kB -76 B (-0.1%)
module 82.2 kB 82.2 kB -18 B (-0.0%)
react-native 82.4 kB 82.4 kB -18 B (-0.0%)
@firebase/functions
Type Base (29d0340) Merge (75779cd) Diff
browser 9.62 kB 9.55 kB -65 B (-0.7%)
esm5 11.7 kB 11.7 kB -36 B (-0.3%)
main 12.6 kB 12.5 kB -55 B (-0.4%)
module 9.62 kB 9.55 kB -65 B (-0.7%)
@firebase/storage
Type Base (29d0340) Merge (75779cd) Diff
browser 55.6 kB 55.6 kB +35 B (+0.1%)
esm5 61.8 kB 61.9 kB +51 B (+0.1%)
main 58.4 kB 58.5 kB +24 B (+0.0%)
module 55.6 kB 55.6 kB +35 B (+0.1%)
@firebase/util
Type Base (29d0340) Merge (75779cd) Diff
browser 22.0 kB 22.6 kB +511 B (+2.3%)
esm5 23.4 kB 24.0 kB +512 B (+2.2%)
main 28.8 kB 29.5 kB +674 B (+2.3%)
module 22.0 kB 22.6 kB +511 B (+2.3%)

`bundle`

31 size changes

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
analytics (logEvent)	42.9 kB	42.9 kB	+21 B (+0.0%)
database (Append to a list of data)	147 kB	148 kB	+256 B (+0.2%)
database (Filtering data)	146 kB	147 kB	+256 B (+0.2%)
database (Listen for child events)	162 kB	163 kB	+256 B (+0.2%)
database (Listen for value events + Detach listeners)	162 kB	163 kB	+256 B (+0.2%)
database (Listen for value events)	162 kB	163 kB	+256 B (+0.2%)
database (Read data once)	162 kB	162 kB	+256 B (+0.2%)
database (Save data as transactions)	164 kB	165 kB	+256 B (+0.2%)
database (Sort data)	148 kB	148 kB	+256 B (+0.2%)
database (Write data)	147 kB	147 kB	+256 B (+0.2%)
firestore (Persistence)	276 kB	276 kB	+252 B (+0.1%)
firestore (Query Cursors)	213 kB	213 kB	+259 B (+0.1%)
firestore (Query)	214 kB	214 kB	+259 B (+0.1%)
firestore (Read data once)	202 kB	202 kB	+259 B (+0.1%)
firestore (Realtime updates)	204 kB	204 kB	+259 B (+0.1%)
firestore (Transaction)	186 kB	186 kB	+259 B (+0.1%)
firestore (Write data)	185 kB	186 kB	+259 B (+0.1%)
firestore-lite (Query Cursors)	71.0 kB	71.3 kB	+259 B (+0.4%)
firestore-lite (Query)	74.2 kB	74.4 kB	+259 B (+0.3%)
firestore-lite (Read data once)	58.6 kB	58.8 kB	+259 B (+0.4%)
firestore-lite (Transaction)	83.2 kB	83.4 kB	+259 B (+0.3%)
firestore-lite (Write data)	68.3 kB	68.6 kB	+259 B (+0.4%)
functions (call)	30.5 kB	30.8 kB	+258 B (+0.8%)
storage (getBytes)	39.7 kB	39.9 kB	+263 B (+0.7%)
storage (getDownloadURL)	41.8 kB	42.0 kB	+263 B (+0.6%)
storage (getMetadata)	41.2 kB	41.5 kB	+263 B (+0.6%)
storage (list + listAll)	40.6 kB	40.9 kB	+263 B (+0.6%)
storage (updateMetadata)	41.5 kB	41.7 kB	+263 B (+0.6%)
storage (uploadBytes)	46.0 kB	46.3 kB	+263 B (+0.6%)
storage (uploadBytesResumable)	55.9 kB	56.2 kB	+361 B (+0.6%)
storage (uploadString)	46.2 kB	46.5 kB	+263 B (+0.6%)

`firebase`

11 size changes

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
firebase-analytics-compat.js	25.8 kB	25.8 kB	+21 B (+0.1%)
firebase-analytics.js	24.9 kB	24.9 kB	+21 B (+0.1%)
firebase-auth-react-native.js	149 kB	149 kB	+296 B (+0.2%)
firebase-compat.js	740 kB	740 kB	+178 B (+0.0%)
firebase-database.js	154 kB	154 kB	+245 B (+0.2%)
firebase-firestore-compat.js	314 kB	314 kB	-1 B (-0.0%)
firebase-firestore-lite.js	88.6 kB	88.8 kB	+227 B (+0.3%)
firebase-firestore.js	314 kB	314 kB	+221 B (+0.1%)
firebase-functions.js	10.5 kB	10.8 kB	+226 B (+2.1%)
firebase-storage-compat.js	38.8 kB	39.0 kB	+158 B (+0.4%)
firebase-storage.js	38.1 kB	38.5 kB	+390 B (+1.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/HdvtvCz3vN.html

google-oss-bot · 2022-10-08T01:09:53Z

Size Analysis Report ¹

Affected Products

@firebase/analytics
- getAnalytics
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.98 kB 10.0 kB +21 B (+0.2%)
  size-with-ext-deps 42.8 kB 42.8 kB +21 B (+0.0%)
- initializeAnalytics
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.88 kB 9.90 kB +21 B (+0.2%)
  size-with-ext-deps 36.0 kB 36.1 kB +21 B (+0.1%)
- isSupported
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.77 kB 9.79 kB +21 B (+0.2%)
  size-with-ext-deps 35.6 kB 35.6 kB +21 B (+0.1%)
- logEvent
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.63 kB 9.65 kB +21 B (+0.2%)
  size-with-ext-deps 35.5 kB 35.5 kB +21 B (+0.1%)
- setAnalyticsCollectionEnabled
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.79 kB 9.81 kB +21 B (+0.2%)
  size-with-ext-deps 35.6 kB 35.7 kB +21 B (+0.1%)
- setConsent
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.76 kB 9.78 kB +21 B (+0.2%)
  size-with-ext-deps 35.6 kB 35.6 kB +21 B (+0.1%)
- setCurrentScreen
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.87 kB 9.89 kB +21 B (+0.2%)
  size-with-ext-deps 35.7 kB 35.7 kB +21 B (+0.1%)
- setDefaultEventParameters
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.74 kB 9.77 kB +21 B (+0.2%)
  size-with-ext-deps 35.6 kB 35.6 kB +21 B (+0.1%)
- setUserId
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.86 kB 9.88 kB +21 B (+0.2%)
  size-with-ext-deps 35.7 kB 35.7 kB +21 B (+0.1%)
- setUserProperties
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.94 kB 9.96 kB +21 B (+0.2%)
  size-with-ext-deps 35.8 kB 35.8 kB +21 B (+0.1%)
- settings
  Size
  Type Base (29d0340) Merge (75779cd) Diff
  size 9.75 kB 9.77 kB +21 B (+0.2%)
  size-with-ext-deps 35.6 kB 35.6 kB +21 B (+0.1%)

`@firebase/database`

`getDatabase`

Size

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
size	116 kB	116 kB	-25 B (-0.0%)
size-with-ext-deps	145 kB	145 kB	+256 B (+0.2%)

External Dependency

Module Base (29d0340) Merge (75779cd) Diff

@firebase/util

25 dependencies

Deferred
Sha1
assert
assertionError
base64
base64Encode
contains
createMockUserToken
deepCopy
errorPrefix
getDefaultEmulatorHost
getModularInstance
isAdmin
isEmpty
isMobileCordova
isNodeSdk
isReactNative
isValidFormat
jsonEval
map
querystring
safeGet
stringLength
stringToByteArray
stringify

25 dependencies

Deferred
Sha1
assert
assertionError
base64
base64Encode
contains
createMockUserToken
deepCopy
errorPrefix
getDefaultEmulatorHostnameAndPort
getModularInstance
isAdmin
isEmpty
isMobileCordova
isNodeSdk
isReactNative
isValidFormat
jsonEval
map
querystring
safeGet
stringLength
stringToByteArray
stringify

+ getDefaultEmulatorHostnameAndPort
- getDefaultEmulatorHost

`@firebase/firestore`

`getFirestore`

Size

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
size	18.5 kB	18.4 kB	-29 B (-0.2%)
size-with-ext-deps	85.0 kB	85.3 kB	+254 B (+0.3%)

External Dependency

Module	Base (`29d0340`)	Merge (`75779cd`)	Diff
`@firebase/util`	FirebaseError createMockUserToken getDefaultEmulatorHost	FirebaseError createMockUserToken getDefaultEmulatorHostnameAndPort	+ getDefaultEmulatorHostnameAndPort - getDefaultEmulatorHost

`@firebase/functions`

`getFunctions`

Size

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
size	2.63 kB	2.60 kB	-25 B (-1.0%)
size-with-ext-deps	26.7 kB	27.0 kB	+258 B (+1.0%)

External Dependency

Module	Base (`29d0340`)	Merge (`75779cd`)	Diff
`@firebase/util`	getDefaultEmulatorHost getModularInstance	getDefaultEmulatorHostnameAndPort getModularInstance	+ getDefaultEmulatorHostnameAndPort - getDefaultEmulatorHost

`@firebase/storage`

_UploadTask
Size
Type Base (29d0340) Merge (75779cd) Diff
size 29.5 kB 29.6 kB +98 B (+0.3%)
size-with-ext-deps 46.5 kB 46.6 kB +98 B (+0.2%)

`getStorage`

Size

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
size	10.5 kB	10.5 kB	-25 B (-0.2%)
size-with-ext-deps	35.3 kB	35.5 kB	+263 B (+0.7%)

External Dependency

Module Base (29d0340) Merge (75779cd) Diff

@firebase/util

FirebaseError
createMockUserToken
getDefaultEmulatorHost
getModularInstance

FirebaseError
createMockUserToken
getDefaultEmulatorHostnameAndPort
getModularInstance

+ getDefaultEmulatorHostnameAndPort
- getDefaultEmulatorHost

uploadBytesResumable
Size
Type Base (29d0340) Merge (75779cd) Diff
size 29.7 kB 29.8 kB +98 B (+0.3%)
size-with-ext-deps 46.7 kB 46.8 kB +98 B (+0.2%)

`@firebase/util`

`getDefaultEmulatorHostnameAndPort`

Size

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
size	?	4.14 kB	? (?)
size-with-ext-deps	?	4.14 kB	? (?)

Dependency

Type	Base (`29d0340`)	Merge (`75779cd`)	Diff
functions	?	getGlobal	?
classes	?		?
variables	?	base64 base64Decode byteArrayToString getDefaultEmulatorHost getDefaultEmulatorHostnameAndPort getDefaults getDefaultsFromCookie getDefaultsFromEnvVariable getDefaultsFromGlobal stringToByteArray$1	?
enums	?		?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/qnr0V7hlqr.html

…//github.com/firebase/firebase-js-sdk into mtewani/fix-exponential-backoff-pause-resume

packages/storage/src/task.ts

Cleaned up timeouts

ac3c2b4

maneesht requested a review from tonyjhuang as a code owner October 8, 2022 00:34

Create great-houses-trade.md

1c0e435

maneesht requested a review from egilmorez as a code owner October 8, 2022 00:34

maneesht added 5 commits October 8, 2022 09:16

Cleanup

595b36f

Merge branch 'mtewani/fix-exponential-backoff-pause-resume' of https:…

10f6097

…//github.com/firebase/firebase-js-sdk into mtewani/fix-exponential-backoff-pause-resume

Removed unnecessary state

6f49afc

Fixed windowd error

195d508

Fixed typings

b0e6d57

tonyjhuang approved these changes Oct 10, 2022

View reviewed changes

packages/storage/src/task.ts Outdated Show resolved Hide resolved

Addressed comment

3cac155

hsubox76 approved these changes Oct 12, 2022

View reviewed changes

maneesht requested a review from markarndt October 12, 2022 16:37

markarndt approved these changes Oct 12, 2022

View reviewed changes

maneesht merged commit 5f55ed8 into master Oct 12, 2022

maneesht deleted the mtewani/fix-exponential-backoff-pause-resume branch October 12, 2022 17:05

google-oss-bot mentioned this pull request Oct 12, 2022

Version Packages #6688

Merged

firebase locked and limited conversation to collaborators Nov 12, 2022

[Storage] Cleared timeouts upon pause/resume of uploads #6667

[Storage] Cleared timeouts upon pause/resume of uploads #6667

Conversation

maneesht commented Oct 8, 2022

changeset-bot bot commented Oct 8, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented Oct 8, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/analytics

@firebase/database

@firebase/firestore

@firebase/firestore-compat

@firebase/firestore-lite

@firebase/functions

@firebase/storage

@firebase/util

bundle

firebase

Test Logs

google-oss-bot commented Oct 8, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/analytics

getAnalytics

initializeAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setConsent

setCurrentScreen

setDefaultEventParameters

setUserId

setUserProperties

settings

@firebase/database

getDatabase

@firebase/firestore

getFirestore

@firebase/functions

getFunctions

@firebase/storage

_UploadTask

getStorage

uploadBytesResumable

@firebase/util

getDefaultEmulatorHostnameAndPort

Test Logs

changeset-bot bot commented Oct 8, 2022 •

edited

Loading

google-oss-bot commented Oct 8, 2022 •

edited

Loading

Size Report ¹

`@firebase/analytics`

`@firebase/database`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Oct 8, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/analytics`

`getAnalytics`

`initializeAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setConsent`

`setCurrentScreen`

`setDefaultEventParameters`

`setUserId`

`setUserProperties`

`settings`

`@firebase/database`

`getDatabase`

`@firebase/firestore`

`getFirestore`

`@firebase/functions`

`getFunctions`

`@firebase/storage`

`_UploadTask`

`getStorage`

`uploadBytesResumable`

`@firebase/util`

`getDefaultEmulatorHostnameAndPort`