Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More logging for npm publish #7327

Merged
merged 2 commits into from
May 24, 2023
Merged

More logging for npm publish #7327

merged 2 commits into from
May 24, 2023

Conversation

hsubox76
Copy link
Contributor

  • Add a workflow option to set NPM publish --verbose option.
  • Only print publish logs if a publish task failed

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5d708c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 24, 2023 21:25
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners May 24, 2023 21:25
dwyfrequency
dwyfrequency approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 24, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (7110588) and merge commit (9700847).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rlkuhoRpzd.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 24, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (7110588) and merge commit (9700847).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UDP8IpgdKx.html

@hsubox76 hsubox76 merged commit 4c492e0 into master May 24, 2023
@hsubox76 hsubox76 deleted the ch-debug-staging branch May 24, 2023 22:08
ch5zzy pushed a commit that referenced this pull request Jun 6, 2023
@hsubox76 @ch5zzy
More logging for npm publish (#7327)
2f5522f
@firebase firebase locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dwyfrequency