Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Small Count API documentation improvements #7933

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 9, 2024

Apply the feedback to the count and aggregation API documentation as suggested in #6608.

Ported to Android in firebase/firebase-android-sdk#5634.
Ported to iOS in firebase/firebase-ios-sdk#12254.
Ported to CPP in firebase/firebase-cpp-sdk#1511.
Ported to Unity in firebase/firebase-unity-sdk#923.
Ported to Node server SDK in googleapis/nodejs-firestore#1974.
Ported to Java server SDK in googleapis/java-firestore#1522.

@dconeybe dconeybe self-assigned this Jan 9, 2024
Copy link

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: b6186b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 9, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 9, 2024

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text edits LGTM, thanks!

packages/firestore/src/lite-api/aggregate.ts Outdated Show resolved Hide resolved
packages/auth/api-extractor.json Outdated Show resolved Hide resolved
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 991fa27 into master Jan 10, 2024
44 checks passed
@dconeybe dconeybe deleted the dconeybe/CountApiDocTweaks branch January 10, 2024 21:20
@firebase firebase locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants