New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemInstruction and toolConfig #8146
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a nit.
packages/vertexai/src/types/enums.ts
Outdated
// or a natural language repspose. | ||
AUTO = 'AUTO', | ||
// Model is constrained to always predicting a function call only. | ||
// If "allowed_function_names" are set, the predicted function call will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, I think this should be "If "allowed function names" is set".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
See parallel GoogleAI JS implementation here: google-gemini/generative-ai-js#89
Add
System instruction design doc here (internal): https://docs.google.com/document/d/14HXjTbm6nJ9wy-TdnU3JdyNW2wQF8DZAmqI7eogHLTg/edit?tab=t.0#heading=h.6xzp689wzd8c