Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemInstruction and toolConfig #89

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Add systemInstruction and toolConfig #89

merged 4 commits into from
Apr 11, 2024

Conversation

hsubox76
Copy link
Collaborator

See parallel Vertex web implementation PR: firebase/firebase-js-sdk#8146

Add

  • systemInstruction
  • toolConfig (forced function calling feature)

System instruction design doc here (internal): https://docs.google.com/document/d/14HXjTbm6nJ9wy-TdnU3JdyNW2wQF8DZAmqI7eogHLTg/edit?tab=t.0#heading=h.6xzp689wzd8c

Swift and Android PRs here:
google-gemini/generative-ai-swift#124
google-gemini/generative-ai-android#112
google-gemini/generative-ai-android#103

Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: e5057ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@hsubox76 hsubox76 merged commit ccdc4f8 into main Apr 11, 2024
3 checks passed
@hsubox76 hsubox76 deleted the ch-system branch April 11, 2024 17:38
@hsubox76 hsubox76 restored the ch-system branch April 11, 2024 18:36
@hsubox76 hsubox76 mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants