Emulator fixes for #1281, #1279, and #1277 #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
May 14, 2019
| externalRoute, | ||
| `${externalRoute}/*`, | ||
| ]; | ||
| const httpsFunctionRoutes = [httpsFunctionRoute, `${httpsFunctionRoute}/*`]; |
There was a problem hiding this comment.
Just want to make sure that callable functions get this treatment, not just "normal" HTTPS functions. Can you confirm (or maybe even add a test)?
There was a problem hiding this comment.
Good point good point, should add a test
There was a problem hiding this comment.
Confirmed callable still work, will look at adding a test, but prolly not for this PR
|
|
Bleh, let's try again then |
samtstern
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this I've done some work to clean up some of our tests and I've refactored
FunctionsEmulatorto use more static methods so it's easier to stub out calls for testing.We also see an introduction of tests for the core emulator "hub" which routes the requests.