Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emulators:export and import for auth. #2955

Merged
merged 6 commits into from
Dec 18, 2020
Merged

Conversation

yuchenshi
Copy link
Member

@yuchenshi yuchenshi commented Dec 17, 2020

Description

Adds support for emulators:export and emulators:start --import.

Scenarios Tested

See end to end test added

Sample Commands

firebase emulators:start
# on separate terminal
firebase emulators:export my-dump

Later: firebase emulators:start --import my-dump.

--export-on-exit should also work, although I didn't test it.

Fixes #2749.

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 17, 2020
@yuchenshi
Copy link
Member Author

Open question: what if you import with a different projectId?

@yuchenshi
Copy link
Member Author

Open question: what if you import with a different projectId?

Removed projectId from exported file path for now. It now exports only from the default projectId and imports only to the default projectId. This is now ready for review.

scripts/triggers-end-to-end-tests/tests.ts Show resolved Hide resolved
src/emulator/hubExport.ts Outdated Show resolved Hide resolved
@yuchenshi yuchenshi merged commit 9e175eb into master Dec 18, 2020
@yuchenshi yuchenshi deleted the ys/auth-export branch December 18, 2020 02:12
@farcondee
Copy link

What's the status on this? It's merged to master but not yet released?

@samtstern
Copy link
Contributor

@farcondee this has been merged and released, if you're using the latest CLI version and having trouble using this please file a new issue!

@farcondee
Copy link

@samtstern My bad, I had an older version. Installed the latest and this fix works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulator export does not save created auth users
4 participants