Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws from 7.2.3 to 7.4.6 #3428

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 30, 2021

Bumps ws from 7.2.3 to 7.4.6.

Release notes

Sourced from ws's releases.

7.4.6

Bug fixes

  • Fixed a ReDoS vulnerability (00c425ec).

A specially crafted value of the Sec-Websocket-Protocol header could be used to significantly slow down a ws server.

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();
value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);
}

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

7.4.5

Bug fixes

  • UTF-8 validation is now done even if utf-8-validate is not installed (23ba6b29).
  • Fixed an edge case where websocket.close() and websocket.terminate() did not close the connection (67e25ff5).

7.4.4

Bug fixes

  • Fixed a bug that could cause the process to crash when using the permessage-deflate extension (92774377).

7.4.3

Bug fixes

  • The deflate/inflate stream is now reset instead of reinitialized when context takeover is disabled (#1840).

7.4.2

Bug fixes

... (truncated)

Commits
  • f5297f7 [dist] 7.4.6
  • 00c425e [security] Fix ReDoS vulnerability
  • 990306d [lint] Fix prettier error
  • 32e3a84 [security] Remove reference to Node Security Project
  • 8c914d1 [minor] Fix nits
  • fc7e27d [ci] Test on node 16
  • 587c201 [ci] Do not test on node 15
  • f672710 [dist] 7.4.5
  • 67e25ff [fix] Fix case where abortHandshake() does not close the connection
  • 23ba6b2 [fix] Make UTF-8 validation work even if utf-8-validate is not installed
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @samtstern.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 30, 2021
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label May 30, 2021
@samtstern
Copy link
Contributor

@dependabot rebase

@samtstern
Copy link
Contributor

@dependabot squash and merge

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.4.6 branch from b3f2054 to 4791851 Compare June 1, 2021 14:26
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 1, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.4.6 branch from 4791851 to 4c36b63 Compare June 1, 2021 17:58
Bumps [ws](https://github.com/websockets/ws) from 7.2.3 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.2.3...7.4.6)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.4.6 branch from 4c36b63 to 42a4b27 Compare June 9, 2021 12:21
@dependabot dependabot bot merged commit 93acb1b into master Jun 9, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ws-7.4.6 branch June 9, 2021 12:25
inlined added a commit that referenced this pull request Jul 3, 2021
* Unbreak build (#3463)

* Unbreak build

* linter changed its mind

* firestore:delete getConfirmationMessage should include current project (#3457)

The firestore:delete command should notify the user of the current project. This should help users minimize chances of accidental deletions when switching between projects.

* Add asia-southeast1 to RTDB CLI (#3460)

* Fix init database without projectId (#3446)

* Fix init database (#3445)

* Added value check for "feature" parameter in init (#3449)

When the optional feature parameter is provided in a `firebase init
[feature]` command, this checks that its value is a valid choice before
attempting any other initialization.

* Bump trim-newlines from 3.0.0 to 3.0.1 (#3471)

Bumps [trim-newlines](https://github.com/sindresorhus/trim-newlines) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/sindresorhus/trim-newlines/releases)
- [Commits](https://github.com/sindresorhus/trim-newlines/commits)

---
updated-dependencies:
- dependency-name: trim-newlines
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 7.2.3 to 7.4.6 (#3428)

* add node16 to tests (#3462)

* Import/export download tokens (#3444)

* Fixes Storage Emulator startup errors (#3478)

* Bump normalize-url from 4.5.0 to 4.5.1 (#3476)

Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes download tokens missing when uploading files via Cloud SDK (#3479)

* Follow up to #3420 (#3437)

* Increase waitForPortClosed timeout to 60s (#3483)

* Added validation logic to allow selectResource param type in extensions.yaml (#3489)

* Fix background functions in functions:shell (#3491)

* 9.13.0

* [firebase-release] Removed change log and reset repo after 9.13.0 release

* Fix ext:update issue where local extension is incorrectly inferred as published extension (#3499)

* Add missing changelog entry for #3499 (#3500)

* Fix init hosting:github (#3503)

* 9.13.1

* [firebase-release] Removed change log and reset repo after 9.13.1 release

* Avoid emulator data loss when there an error during export (#3511)

* Ask before overwriting storage.rules (#3510)

* Update CONTRIBUTING.md (#3513)

added note to run `npm install` before `npm link` the first time

* Release Cloud Firestore Emulator v1.13.0. (#3515)

* Basic create support

This change adds support for `firebase --open-sesame golang`.

After running this command, `firebase init` will support Go 1.13
as a langauge for Cloud Functions.

Limitations:

1. .gitignore is empty
2. Customers cannot mix Node and Go code (WAI)
3. There is little validation being done of customer code
4. The actual deployed function params are hard coded; SDK incoming

* Use vendoring to fetch SDK

* Update sample code

* Simplify unarchive pipe

* TSLint

* PR feedback

* Delete Container Registry images left after Functions deployment (#3439)

* Delete Container Registry images left after Functions deployment

* Simplify caching

* Improve error handling and report next steps to users

* lint fixes

* Fix typo

* Increase max function ID length to 63 (#3521)

* Fix crash when deploying zero functions. (#3520)

Previously most code read the desired backend from
`options.config.get("functions.backend")` which was set to the
empty backend correctly. Code that depended on payload.functions.backend
crashed because payload.functions was null when the backend was
empty.

Since optins.config should be firebase.json data, this change
normalizes on payload.functions.backend and ensures that it
is never null while options.config.get('functions') is present
(i.e. when the customer has functions to deploy).

* Use proper replace and get commands

* Update changelog with my recent pushes (#3522)

* 9.14.0

* [firebase-release] Removed change log and reset repo after 9.14.0 release

* Bump glob-parent from 5.0.0 to 5.1.2 (#3472)

* Added deferred provisioning check for Storage and Authentication during extension install (#3497)

Implemented provisioning check helper which checks whether products use by the extension are fully provisioned.

* Generate JSON Schema for firebase.json (#3505)

* Fetch from newly public GH repo

* PR feedback

* Format

Co-authored-by: davidbrenner <david.a.brenner@gmail.com>
Co-authored-by: Fred Zhang <fredzqm@google.com>
Co-authored-by: Sam Stern <samstern@google.com>
Co-authored-by: Andrew Heard <andrew@wizheard.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bryan Kendall <bkend@google.com>
Co-authored-by: Abe Haskins <abeisgreat@abeisgreat.com>
Co-authored-by: Enrico Graziani <mrenrich84@gmail.com>
Co-authored-by: Pavel Jbanov <pavelgj@gmail.com>
Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
Co-authored-by: huangjeff5 <64040981+huangjeff5@users.noreply.github.com>
Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant