Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional fields into build and copy to backend #4746

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

colerogers
Copy link
Contributor

Fixes #4744

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #4746 (d91d37b) into master (4992be4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4746      +/-   ##
==========================================
+ Coverage   57.57%   57.59%   +0.02%     
==========================================
  Files         287      287              
  Lines       18511    18518       +7     
  Branches     3620     3622       +2     
==========================================
+ Hits        10658    10666       +8     
+ Misses       6979     6978       -1     
  Partials      874      874              
Impacted Files Coverage Δ
src/deploy/functions/build.ts 74.59% <100.00%> (+1.54%) ⬆️
...rc/deploy/functions/runtimes/discovery/v1alpha1.ts 79.88% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4992be4...d91d37b. Read the comment docs.

Copy link
Contributor

@Berlioz Berlioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colerogers colerogers merged commit 390f096 into master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants