Web Frameworks refactor & new features #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
commented
Aug 12, 2022
jamesdaniels
commented
Aug 12, 2022
jamesdaniels
commented
Aug 12, 2022
jamesdaniels
added a commit
to FirebaseExtended/firebase-framework-tools
that referenced
this pull request
Aug 16, 2022
* Addressed Angular not working, `defaultProject` is gone in new projects now * Added more error logging to the Angular codepath * `npm run dev` wasn't patching the globally installed CLI * Bumped version * Migrating to ESM * Adding nuxt & nuxt3 to Github Actions * Bumping deps * Fix dynamic import paths in Windows with pathToFileURL * Adding Windows tests to Actions * Marked as compatible with Node 16, 18. * Dropped Node 14 from Actions * Pack filesystem NPM overrides * Console log NPM install * Integrate with [firebase-js-sdk#6526](firebase/firebase-js-sdk#6526) and [firebase-tools##4868](firebase/firebase-tools#4868) * Next broke, `next export` no longer fails for fallbacks and api routes, detect these to determine if a Cloud Function should be spun up * Fixed relative directory handling * Silenced next export failures by spawning * Rearranged framework detection order so custom servers are first * Error if it could not determine the framework * Next minimal mode
…, and reduce noise on npm i
jamesdaniels
commented
Sep 14, 2022
src/frameworks/angular/index.ts
Outdated
| }; | ||
|
|
||
| // TODO memoize, dry up | ||
| const getContext = async (dir:string) => { |
jamesdaniels
commented
Sep 14, 2022
Codecov ReportBase: 57.16% // Head: 55.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4868 +/- ##
==========================================
- Coverage 57.16% 55.91% -1.25%
==========================================
Files 295 305 +10
Lines 19633 20305 +672
Branches 3919 4090 +171
==========================================
+ Hits 11223 11354 +131
- Misses 7459 7996 +537
- Partials 951 955 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bkendall
approved these changes
Sep 27, 2022
christhompsongoogle
pushed a commit
that referenced
this pull request
Sep 30, 2022
* First * Cleanup * Frameworks@canary * Add GCLOUD_PROJECT for SSG * Framework init * Bump * NPM install on Nuxt, prompt for Angular Universal * Fix next static export add minimal mode * npx latest, detect framework in ., bump version * Minor fixes for deploy * Path fixes for spawn, addressed relative path issue with injectConfig, and reduce noise on npm i * Bump version * Add Vite init * Refactoring * Get Angular working completely again * Flushing out refactored Next.js * Getting Vite and Express running again * Fix abs vs. relative dirs, bundle next.config.js * Only delete the hosting dir, if it exists * Rearrange things * Getting Nuxt working * Was touching a devDep * Breaking out the vite templates * Fixed lit discovery * Autoinit * Fix for the function name and pathing for execSync * Drop sveltekit * Lint and cleanup * Fix dynamic import on windows * Target firebase-frameworks 0.6.0 * Cleanup and addressing feedback * Fix for existing functions config being an object * Go for a simpler dep resolution * Dont use eval for dynamic import * fix for skipLibChecks * destructure vs. passing NODE_ENV manually * Cleanup * Double join * Lint * Cleanup superstatic after.files * Eslint comment * Cleanup with promptOnce * Refactor express * Proxy cleanup * next.js => next * revert the ordering change for emulator starting * make build command work on windows Co-authored-by: David East <deast@google.com> Co-authored-by: David East <davideast@users.noreply.github.com> Co-authored-by: Bryan Kendall <bkend@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes firebase-framework-tools#24 alongside firebase-js-sdk#6526.
There are a number of improvements here but most importantly this serves as the PoC for go/firebase-api-client-autoinit,
firebase hosting initfor Web Frameworks, and is moving the majority of the logic fromfirebase-framework-toolsto this repo.firebase-framework-toolswill still be used as the runtime harness for SSR in Cloud Functions.??=, so that developers can opt-outNODE_ENVstuff is because Next.js (a dev dep) is adding to NodeJS.ProcessEnvskipLibCheckfor now