Fix firebase storage resumable uploads #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 57.16% // Head: 57.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5018 +/- ##
==========================================
+ Coverage 57.16% 57.17% +0.01%
==========================================
Files 295 295
Lines 19633 19633
Branches 3919 3919
==========================================
+ Hits 11223 11225 +2
+ Misses 7459 7457 -2
Partials 951 951
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abhis3
reviewed
Sep 26, 2022
| @@ -332,6 +332,43 @@ describe("Firebase Storage endpoint conformance tests", () => { | |||
| }) | |||
| .expect(400); | |||
| }); | |||
|
|
|||
| it("hould handle resumable uploads with without upload protocol set", async () => { | |||
This was referenced Sep 26, 2022
christhompsongoogle
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Fix firebase storage resumable uploads * Update changelog * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where resumable uploads were not working properly #4927
Scenarios Tested
Reproduced issue locally and also added new test that matches the conformance tests too.