-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-upgrade/downgrade implicit concurrency with CPU changes #5196
Conversation
Codecov ReportBase: 56.22% // Head: 56.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5196 +/- ##
=======================================
Coverage 56.22% 56.22%
=======================================
Files 308 308
Lines 20752 20757 +5
Branches 4206 4210 +4
=======================================
+ Hits 11667 11670 +3
Misses 8071 8071
- Partials 1014 1016 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Updated to also upgrade concurrency when it is not specified and CPU grows to support it. |
src/deploy/functions/prepare.ts
Outdated
// turn off concurrency. We'll not do the opposite and turn on concurrency | ||
// if there are >1 CPU because this could expose race conditions. They | ||
// either need to start on concurrency where they've always needed to | ||
// handle race conditions, or they should explicitly enable. | ||
// We'll hanndle this in setCpuAndConcurrency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment seems inaccurate w/ latest implementation. We do upgrade concurrency regardless, ignoring race condition.
057e4b4
to
f4caad0
Compare
Concurrency will aggressively default to 80 per #5196.
Concurrency will aggressively default to 80 per #5196.
Potential fix for #1288 if we decide to take it. We can decide to: