Firestore deploy works with multiple databases b/267549787

[VicVer09]

b/267549787

Manual testing instructions:

• checkout branch (see go/firebase-cli-contributor for detailed setup guide)
• npm link
  in a separate directory:
• create gcp project (using gcloud, api, or ui)
• create firebase project or using firebase tools
• add project to multiple databases allowlist go/firestore-enable-multiple-databases
• firebase init with firestore enabled in a separate directory
• create default database (using gcloud, api, or ui)
• create a named database (using api)
• configure rules for both databases in separate files (sample https://github.com/firebase/quickstart-js/blob/master/firestore/firestore.indexes.json)
• configure indexes for both in separate files (sample https://firebase.google.com/docs/firestore/security/get-started#deny-all)
• configure firebase.json to contain:

    {
      "database": "(default)",
      "rules": "firestore.rules",
      "indexes": "firestore.indexes.json"
    },
    {
      "database": "named",
      "rules": "named.rules",
      "indexes": "named.indexes.json"
    }
  ]

• run firebase deploy --only firestore
• check composite indexes are updated using gcloud:
  gcloud firestore indexes composite list --database named
gcloud firestore indexes composite list --database \(default\)
• check rules are updated for default by checking ui
• check rules are updated for named db by trying to write a document to named database using api
• modify rules/indexes slightly and deploy again, verify the changes are picked up

[codecov-commenter]

Codecov Report

Base: 55.99% // Head: 55.99% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5ed7c37) compared to base (d08a2ab).
Patch coverage: 9.52% of modified lines in pull request are covered.

Additional details and impacted files

@@               Coverage Diff               @@
##           victorvim-main    #5553   +/-   ##
===============================================
  Coverage           55.99%   55.99%           
===============================================
  Files                 317      318    +1     
  Lines               21612    21563   -49     
  Branches             4420     4403   -17     
===============================================
- Hits                12101    12075   -26     
+ Misses               8454     8426   -28     
- Partials             1057     1062    +5     

Impacted Files	Coverage Δ
src/firestore/indexes.ts	31.39% <0.00%> (ø)
src/deploy/firestore/prepare.ts	18.91% <5.00%> (+1.27%)	⬆️
src/deploy/firestore/deploy.ts	22.58% <5.26%> (-8.19%)	⬇️
src/firestore/fsConfig.ts	7.50% <9.09%> (ø)
src/deploy/firestore/release.ts	26.66% <18.18%> (-6.67%)	⬇️
src/rulesDeploy.ts	95.41% <100.00%> (ø)
src/extensions/manifest.ts	77.77% <0.00%> (-4.28%)	⬇️
src/deploy/hosting/convertConfig.ts	73.68% <0.00%> (-2.29%)	⬇️
src/prompt.ts	94.44% <0.00%> (-0.56%)	⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.