Handle deletion of objects in the storage emulator for the API v1 #5598
Conversation
Head branch was pushed to by a user without write access
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5598 +/- ##
=======================================
Coverage 55.92% 55.92%
=======================================
Files 322 322
Lines 21706 21706
Branches 4427 4427
=======================================
Hits 12140 12140
Misses 8501 8501
Partials 1065 1065
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Hey @tonyjhuang, do I need to increase the test coverage in order for the CR to be merged? |
|
Hey @ybourgery, sorry for the delay on this. For security reasons, we can't run the integration tests on CI for external contributions. I will run them locally, and then merge this once they pass. Thanks for your contribution! |
|
Ran the integration tests locally for this and they LGTM. |
…rebase#5598) * Handle deletion of objects in the storage emulator for the API v1 * Fix linting issues --------- Co-authored-by: Tony Huang <tony.huang.jun@gmail.com> Co-authored-by: joehan <joehanley@google.com>
Description
The Storage emulator supports the v1 for listing, getting, and creating the objects but not for deleting an object. It prevents the usage of a client library for GCP Cloud Storage (e.g. the one in Go).