-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increases timeOut for detectFromPort to avoid sporadic deployment fails #6888
Increases timeOut for detectFromPort to avoid sporadic deployment fails #6888
Conversation
Co-authored-by: Himanshu Chaudhary <himanshu.cy@gmail.com>
f8e2197
to
f4e5156
Compare
Any updates here? Would be great to see this suggestion finally merged 🙏 |
@Matt-Jennings-GitHub The issue corresponding to this PR is closed, so this PR may never be reviewed. If you follow the comments below and create an issue, the maintainer may respond to the issue. (I have not been able to create an Issue because our code is used in production and it is hard to reproduce and report problems.) |
Thanks @takahashi-shotaro - also in prod. here but will see what I can do |
Hello, because of the underlying issue many colleagues of mine can not perform deployments and are totally blocked. Is there any chance to see this integrated? Thanks! |
Hey @takahashi-shotaro UPD I just tested the solution with a custom bash script that updates the firebase-tools source by explicitly passing the timeout value instead of relying on the default one I believe the more complex code someone will have the more time it might take for Firebase CLI to wait for the server to be ready to return the So changing one hard-coded value onto another is not a solution at all, we should provide a dynamic option instead |
IMO, It would be better to simply report a time elapsed warning instead of forcing a stop at a timeout (at least on the local machine). |
Co-authored-by: @himanshu810e
Description
fix #5888 (This staled issue has a lot of comments attached to it, but it has not been re-opened.)
This comment stating that the issue was resolved by extending the timeout has received many reactions.
This PR is based on #5834 with additional comments. #5834 has not been reviewed for a long time (perhaps the reviewer is not active?).
Scenarios Tested
Sample Commands