Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop timeout on loading code in functions and simply warn #7167

Conversation

takahashi-shotaro-al
Copy link

@takahashi-shotaro-al takahashi-shotaro-al commented May 11, 2024

Description

fix #7165

On a low-spec machine or Windows, it is slower than the actual deployment environment and may take more than 10 seconds to load the source code for functions. ( microsoft/Windows-Dev-Performance#17 )

Scenarios Tested

We now have emulators:start working in our production code.

Sample Commands

@joehan
Copy link
Contributor

joehan commented May 21, 2024

Thanks for the contribution! We're not comfortable getting rid of this timeout fully, so we are going to go with #7176 instead, which will let you configure this timeout by setting FUNCTIONS_DISCOVERY_TIMEOUT.

@joehan joehan closed this May 21, 2024
@joehan joehan removed the request for review from inlined May 21, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the functions code takes a long time to load, an error will occur and loading will be interrupted
2 participants