sql:migrate --force shouldn't prompt
#7208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
changed the title
sql:migrate --force shouldn't prompt
rosalyntan
reviewed
May 22, 2024
| ): Promise<"none" | "safe" | "all"> { | ||
| err: IncompatibleSqlSchemaError | undefined, | ||
| validateOnly: boolean, | ||
| ): Promise<"none" | "all"> { |
There was a problem hiding this comment.
Since there's only two options now, should this return Promise<false | true>? Also does maybeExecuteSchemaMigration better describe what this method does?
There was a problem hiding this comment.
This method doesn't execute schema migration. It determines whether to execute it later.
Well, keeping it as string merely because we will have a "compatible" mode soon. At least 3 value enum is needed here.
rosalyntan
approved these changes
May 22, 2024
|
Thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7208 +/- ##
==========================================
- Coverage 54.10% 54.06% -0.05%
==========================================
Files 387 386 -1
Lines 26094 26108 +14
Branches 5358 5361 +3
==========================================
- Hits 14119 14115 -4
- Misses 10715 10733 +18
Partials 1260 1260 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
firebase dataconnect:sql:migrate --forceshould never prompt.firebase dataconnect:sql:migrateshould prompt for schema migrations and then abort if there is invalid connectors. This way developers can see the SQL before taking the suggesting and run it with--force.Scenarios Tested
Sample Commands
Without invalid connectors
firebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forceWith invalid connectors
firebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --force