Fix data connect emulator listen address. #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
approved these changes
May 23, 2024
dconeybe
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
May 23, 2024
In cl/636395279 the grpc and http ports were combined. Also, that CL changes the --grpc_port and --http_port flags into a single flag: --listen, whose default value is 127.0.0.1:3628. This change will be included in the v1.1.18 release of the Data Connect emulator, and will be used by firestore-tools with firebase/firebase-tools#7211 merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the CLI pass
--listen=127.0.0.1:9399,[::1]:9399instead of--http_portand--grpc_portto the Data Connect emulator.This removes the spearate GRPC port because a single port can now handle both HTTP and GRPC.
It also fixes a bug where the Data Connect emulator listens on all addresses instead of
127.0.0.1regardless of config infirebase.json.Scenarios Tested
Ran a local build of a Data Connect emulator with the CLI and verified it responds to both GRPC and HTTP under both
127.0.0.1:9399and[::1]:9399.Sample Commands
firebase emulators:start