Skip to content

Commit

Permalink
fix(core, windows): fix release build of Firebase Auth, Firestore and…
Browse files Browse the repository at this point in the history
… Storage on Windows (#11997)
  • Loading branch information
cynthiajoan committed Dec 8, 2023
1 parent 606dd3a commit 12b186a
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/firebase_core/firebase_core/windows/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,9 @@ endif()
add_subdirectory(${FIREBASE_CPP_SDK_DIR} bin/ EXCLUDE_FROM_ALL)
target_include_directories(${PLUGIN_NAME} INTERFACE
"${FIREBASE_CPP_SDK_DIR}/include")
set(FIREBASE_LIBS firebase_app)
foreach(firebase_lib IN ITEMS ${FIREBASE_LIBS})

set(FIREBASE_RELEASE_PATH_LIBS firebase_app firebase_auth firebase_storage firebase_firestore)
foreach(firebase_lib IN ITEMS ${FIREBASE_RELEASE_PATH_LIBS})
get_target_property(firebase_lib_path ${firebase_lib} IMPORTED_LOCATION)
string(REPLACE "Debug" "Release" firebase_lib_release_path ${firebase_lib_path})
set_target_properties(${firebase_lib} PROPERTIES
Expand All @@ -125,6 +126,7 @@ foreach(firebase_lib IN ITEMS ${FIREBASE_LIBS})
)
endforeach()

set(FIREBASE_LIBS firebase_app)
set(ADDITIONAL_LIBS advapi32 ws2_32 crypt32 rpcrt4 ole32 icu)

target_link_libraries(${PLUGIN_NAME} PUBLIC "${FIREBASE_LIBS}" "${ADDITIONAL_LIBS}")
Expand Down

0 comments on commit 12b186a

Please sign in to comment.