-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore, apple): issue where setting persistence caused a crash. kFIRFirestoreCacheSizeUnlimited
no longer usable.
#11174
Conversation
kFIRFirestoreCacheSizeUnlimited
no longer usable.kFIRFirestoreCacheSizeUnlimited
no longer usable.
kFIRFirestoreCacheSizeUnlimited
no longer usable.kFIRFirestoreCacheSizeUnlimited
no longer usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a comment on the deprecated constant
|
||
if (persistEnabled) { | ||
NSNumber *unlimitedPersistence = | ||
[NSNumber numberWithLongLong:kFIRFirestoreCacheSizeUnlimited]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this constant created by us or was it exposed by the Firebase SDK? Should we ask the Firebase iOS SDK explanations about it if it's exposed by the native sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's one of the SDKs constants. Worth asking in the next meeting 👍
Description
A few things to note.
kFIRFirestoreCacheSizeUnlimited
& anything more/less than acceptable cache size (1mb/100mb) was crashing apple apps.copy()
function ofSettings
, cannot do on creation ofSettings
as it would change the user facing API fromconst Settings
toSettings(cacheSizeBytes: 10000000)
.Related Issues
fix: #11138
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?