fix(firestore, apple): issue where setting persistence caused a crash. kFIRFirestoreCacheSizeUnlimited no longer usable.
#11174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
kFIRFirestoreCacheSizeUnlimited no longer usable.kFIRFirestoreCacheSizeUnlimited no longer usable.
Salakar
changed the title
kFIRFirestoreCacheSizeUnlimited no longer usable.kFIRFirestoreCacheSizeUnlimited no longer usable.
Lyokone
approved these changes
Jun 23, 2023
Contributor
Lyokone
left a comment
Lyokone
left a comment
There was a problem hiding this comment.
LGTM just a comment on the deprecated constant
|
|
||
| if (persistEnabled) { | ||
| NSNumber *unlimitedPersistence = | ||
| [NSNumber numberWithLongLong:kFIRFirestoreCacheSizeUnlimited]; |
Contributor
There was a problem hiding this comment.
Was this constant created by us or was it exposed by the Firebase SDK? Should we ask the Firebase iOS SDK explanations about it if it's exposed by the native sdk?
Member
Author
There was a problem hiding this comment.
Yeah, it's one of the SDKs constants. Worth asking in the next meeting 👍
Salakar
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few things to note.
kFIRFirestoreCacheSizeUnlimited& anything more/less than acceptable cache size (1mb/100mb) was crashing apple apps.copy()function ofSettings, cannot do on creation ofSettingsas it would change the user facing API fromconst SettingstoSettings(cacheSizeBytes: 10000000).Related Issues
fix: #11138
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?