Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(firebase_database_platform_interface): fix analyzer issue introduced in Flutter 3.0.0 #8652

Conversation

nilsreichardt
Copy link
Contributor

Description

Flutter 3.0.0 caused failing the CI: https://github.com/firebase/flutterfire/runs/6398175458?check_suite_focus=true

Nils-MBP-13-M1-3:firebase_database_platform_interface nils$ flutter analyze
Running "flutter pub get" in firebase_database_platform_interface...      1,625ms
Analyzing firebase_database_platform_interface...                       

warning • The '!' will have no effect because the receiver can't be null • test/method_channel_test.dart:32:41 • unnecessary_non_null_assertion

1 issue found. (ran in 2.7s)

Related Issues

Closes #8647
Part of #8644

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

… test/method_channel_test.dart:32:41 • unnecessary_non_null_assertion`
@nilsreichardt
Copy link
Contributor Author

nilsreichardt commented May 12, 2022

cc: @Salakar (tagging you because it fixes the broken CI pipeline, see #8644)

@nilsreichardt nilsreichardt changed the title refactor(firebase_database_platform_interface): fix analyze issue introduced in Flutter 3.0.0 refactor(firebase_database_platform_interface): fix analyzer issue introduced in Flutter 3.0.0 May 12, 2022
@nilsreichardt
Copy link
Contributor Author

The e2e/ios job fails because of #8656. PR for a fix: #8657

@russellwheatley russellwheatley merged commit b781153 into firebase:master May 12, 2022
@firebase firebase locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_database_platform_interface] flutter analyze fails with Flutter 3.0.0
3 participants