Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage, windows): Add windows support #11617

Merged
merged 69 commits into from Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from 60 commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
8cff974
pigeon template setup
Aug 9, 2023
ad65a22
Merge https://github.com/firebase/flutterfire into feat/storage_pigeon
Aug 9, 2023
194d552
make storage macOS running
Aug 10, 2023
ad61702
method channel implementation update
Aug 17, 2023
551f3f8
android compilable
Aug 22, 2023
72b68a5
android emulator upload succeed
Aug 27, 2023
d10b92e
add more task listener
Aug 27, 2023
8449cc5
Get event channel working
Aug 31, 2023
3262fd8
pause iOS for now
Sep 6, 2023
54dd5a2
Merge https://github.com/firebase/flutterfire into feat/storage_pigeon
Sep 6, 2023
89fef3b
first windows checkin
Sep 7, 2023
abd7a71
update message.dart async
Sep 7, 2023
edfa01e
Merge branch 'feat/storage_pigeon' of https://github.com/firebase/flu…
Sep 7, 2023
bab59b9
compilable example
cynthiajoan Sep 11, 2023
e2248e7
add the c++ into pubspec
cynthiajoan Sep 12, 2023
48f0a65
Merge https://github.com/firebase/flutterfire into feat/storage_windows
cynthiajoan Sep 12, 2023
a2af302
cmake changes to test the mono cpp lib
cynthiajoan Sep 14, 2023
7359bbc
Merge https://github.com/firebase/flutterfire into feat/storage_windows
cynthiajoan Sep 18, 2023
8f2a51c
make windows event channel working
cynthiajoan Sep 19, 2023
8392b79
Implement more Storage for iOS functionality
a-maurice Sep 20, 2023
6dff6be
Merge https://github.com/firebase/flutterfire into feat/storage_windows
cynthiajoan Sep 20, 2023
750723c
Merge branch 'feat/storage_pigeon' into feat/storage_windows
cynthiajoan Sep 20, 2023
effcb02
sdk demo ready
cynthiajoan Sep 22, 2023
bee15fb
make ios e2e test build
cynthiajoan Oct 4, 2023
c9a0f7b
Merge branch 'feat/storage_pigeon' into feat/storage_windows
cynthiajoan Oct 4, 2023
ec0f12a
more e2e test fix
cynthiajoan Oct 4, 2023
06cd1d1
Merge branch 'feat/storage_pigeon' into feat/storage_windows
cynthiajoan Oct 4, 2023
7433334
update with pigeon/messages.dart change
cynthiajoan Oct 5, 2023
eb7b918
fix the error message
cynthiajoan Oct 5, 2023
1a5c466
make e2e test pass (android)
cynthiajoan Oct 10, 2023
103ffca
android e2e test
cynthiajoan Oct 11, 2023
b9ad829
make storage iOS pass e2e
cynthiajoan Oct 12, 2023
ccacebf
Merge https://github.com/firebase/flutterfire into feat/storage_pigeon
cynthiajoan Oct 12, 2023
daf7836
Add license header
cynthiajoan Oct 12, 2023
10bdfe4
Merge branch 'feat/storage_pigeon' into feat/storage_windows
cynthiajoan Oct 12, 2023
93651ce
code format
cynthiajoan Oct 13, 2023
66dc646
Update unit test, remove ones that's not work with pigeon
cynthiajoan Oct 13, 2023
5b2e4d2
add symbolic link for macos files
cynthiajoan Oct 15, 2023
f507997
make pigeon generated compatible with both iOS and macOS
cynthiajoan Oct 15, 2023
e0d508c
fix for analyze check
cynthiajoan Oct 16, 2023
6a010bb
add missing analyze fix
cynthiajoan Oct 16, 2023
6bc77b3
more touch
cynthiajoan Oct 16, 2023
210343b
Merge https://github.com/firebase/flutterfire into feat/storage_pigeon
cynthiajoan Oct 17, 2023
9b850c9
get windows pass e2e tests
cynthiajoan Oct 17, 2023
0e033c4
more e2e fix
cynthiajoan Oct 18, 2023
87654b8
Merge branch 'master' into feat/storage_windows
cynthiajoan Oct 18, 2023
f899248
address part of review comments, majorly android ones
cynthiajoan Oct 19, 2023
870432c
format changes
cynthiajoan Oct 19, 2023
4560ca8
addressing the iOS feedback
cynthiajoan Oct 19, 2023
aa751bb
update with cleanup
cynthiajoan Oct 19, 2023
6c647a5
address the analyze check
cynthiajoan Oct 19, 2023
b76cdfd
update e2e test for windows
cynthiajoan Oct 19, 2023
9a3b8b8
Merge branch 'feat/storage_pigeon' into feat/storage_windows
cynthiajoan Oct 19, 2023
ff34ab1
Merge branch 'feat/storage_windows' of https://github.com/firebase/fl…
cynthiajoan Oct 19, 2023
83db9c2
fix a few e2e issue
cynthiajoan Oct 20, 2023
35b7ce1
fix the get data return value
cynthiajoan Oct 20, 2023
90a88c2
Merge branch 'master' into feat/storage_windows
cynthiajoan Oct 22, 2023
1a281c8
to address some review comments
cynthiajoan Oct 22, 2023
addafeb
Merge branch 'master' into feat/storage_windows
cynthiajoan Oct 23, 2023
7cbf1a2
remove the example auto generate test
cynthiajoan Oct 23, 2023
033f1c9
update pigeon version
cynthiajoan Oct 23, 2023
686110f
some tweak
cynthiajoan Oct 23, 2023
451222d
add comments for a sleep timing
cynthiajoan Oct 23, 2023
09b892a
format cpp and objc files
cynthiajoan Oct 24, 2023
c044f8a
add header comments
cynthiajoan Oct 24, 2023
d205ba4
remove debug output
cynthiajoan Oct 24, 2023
4eb324d
remove dart debug output
cynthiajoan Oct 24, 2023
e64e978
more format fix
cynthiajoan Oct 24, 2023
88ed6ce
fix the analyze
cynthiajoan Oct 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -64,7 +64,7 @@ apply_standard_settings(flutter_wrapper_plugin)
set_target_properties(flutter_wrapper_plugin PROPERTIES
POSITION_INDEPENDENT_CODE ON)
set_target_properties(flutter_wrapper_plugin PROPERTIES
CXX_VISIBILITY_PRESET hidden)
cynthiajoan marked this conversation as resolved.
Show resolved Hide resolved
CXX_VISIBILITY_PRESET default)
target_link_libraries(flutter_wrapper_plugin PUBLIC flutter)
target_include_directories(flutter_wrapper_plugin PUBLIC
"${WRAPPER_ROOT}/include"
Expand Down
Expand Up @@ -48,7 +48,7 @@ target_link_libraries(${PLUGIN_NAME} PRIVATE "${firebase_libs}")

target_include_directories(${PLUGIN_NAME} INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/include")
target_link_libraries(${PLUGIN_NAME} PRIVATE flutter flutter_wrapper_plugin)
target_link_libraries(${PLUGIN_NAME} PUBLIC flutter flutter_wrapper_plugin)

# List of absolute paths to libraries that should be bundled with the plugin.
# This list could contain prebuilt libraries, or libraries created by an
Expand Down
Expand Up @@ -59,7 +59,7 @@ apply_standard_settings(flutter_wrapper_plugin)
set_target_properties(flutter_wrapper_plugin PROPERTIES
POSITION_INDEPENDENT_CODE ON)
set_target_properties(flutter_wrapper_plugin PROPERTIES
CXX_VISIBILITY_PRESET hidden)
CXX_VISIBILITY_PRESET default)
target_link_libraries(flutter_wrapper_plugin PUBLIC flutter)
target_include_directories(flutter_wrapper_plugin PUBLIC
"${WRAPPER_ROOT}/include"
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_core/firebase_core/windows/CMakeLists.txt
Expand Up @@ -105,11 +105,11 @@ endforeach()

set(ADDITIONAL_LIBS advapi32 ws2_32 crypt32 rpcrt4 ole32 icu)

target_link_libraries(${PLUGIN_NAME} PRIVATE "${FIREBASE_LIBS}" "${ADDITIONAL_LIBS}")
target_link_libraries(${PLUGIN_NAME} PUBLIC "${FIREBASE_LIBS}" "${ADDITIONAL_LIBS}")

target_include_directories(${PLUGIN_NAME} INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/include")
target_link_libraries(${PLUGIN_NAME} PRIVATE flutter flutter_wrapper_plugin)
target_link_libraries(${PLUGIN_NAME} PUBLIC flutter flutter_wrapper_plugin)

# List of absolute paths to libraries that should be bundled with the plugin.
# This list could contain prebuilt libraries, or libraries created by an
Expand Down
Expand Up @@ -96,6 +96,7 @@ void FirebaseCorePlugin::InitializeApp(
const std::string &app_name,
const PigeonFirebaseOptions &initialize_app_request,
std::function<void(ErrorOr<PigeonInitializeResponse> reply)> result) {
std::cout << "FirebaseCorePlugin::InitializeApp()" << std::endl;
// Create an app
App *app =
App::Create(PigeonFirebaseOptionsToAppOptions(initialize_app_request),
Expand Down