feat(storage, windows): Add windows support #11617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tterfire into feat/storage_windows
…utterfire into feat/storage_windows
cynthiajoan
commented
Oct 23, 2023
| } | ||
| PigeonFullMetaData pigeonData; | ||
| pigeonData.set_metadata(ConvertMedadataToPigeon(result_meta)); | ||
| const flutter::EncodableMap* meta_map = pigeonData.metadata(); |
jonsimantov
reviewed
Oct 23, 2023
packages/firebase_auth/firebase_auth/example/windows/flutter/CMakeLists.txt
Outdated
Show resolved
Hide resolved
russellwheatley
approved these changes
Oct 24, 2023
Lyokone
approved these changes
Oct 24, 2023
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Oct 29, 2023
* pigeon template setup * make storage macOS running * method channel implementation update * android compilable * android emulator upload succeed * add more task listener * Get event channel working * pause iOS for now * first windows checkin * update message.dart async * compilable example * add the c++ into pubspec * cmake changes to test the mono cpp lib * make windows event channel working * Implement more Storage for iOS functionality * sdk demo ready * make ios e2e test build * more e2e test fix * update with pigeon/messages.dart change * fix the error message * make e2e test pass (android) * android e2e test * make storage iOS pass e2e * Add license header * code format * Update unit test, remove ones that's not work with pigeon * add symbolic link for macos files * make pigeon generated compatible with both iOS and macOS * fix for analyze check * add missing analyze fix * more touch * get windows pass e2e tests * more e2e fix * address part of review comments, majorly android ones * format changes * addressing the iOS feedback * update with cleanup * address the analyze check * update e2e test for windows * fix a few e2e issue * fix the get data return value * to address some review comments * remove the example auto generate test * update pigeon version * some tweak * add comments for a sleep timing * format cpp and objc files * add header comments * remove debug output * remove dart debug output * more format fix * fix the analyze --------- Co-authored-by: Cynthia Jiang <cynthiajiang@google.com> Co-authored-by: a-maurice <amaurice@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?