fix plugins README google-services dependency from 4.3.0 to 4.2.0 #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
README to 5 plugins (firebase_auth, firebase_crashlytics, firebase_in_app_messaging, firebase_messaging, firebase_remote_config) contain Android integration instruction.
Using
classpath 'com.google.gms:google-services:4.3.0
fails gradle builds as not supported. Usingclasspath 'com.google.gms:google-services:4.2.0
solves the problem, but many people struggle for nothing before they actually find it. I perform initial issues triage influtter/flutter
and encounter this issue too many times already. This PR doesn't fix this incompatibility at all, but at least doesn't mislead people.Related Issues
In general this upvoted comment prevented a lot of issues. Some of them we close as duplicates.
These are examples of resolved issues.
flutter/flutter#37081
flutter/flutter#38163
flutter/flutter#41492
flutter/flutter#41769
Checklist
I don't think there may be possible any tests. The PR is so trivial that almost all the statements below are irrelevant, so just marking them.
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?