fix(firebase_analytics): support complex data structures like list and map on Android

[lColinDl]

Description

The native Android implementation of the firebase_analytics plugin does not support passing complex data structures (e.g. lists) as parameters into the logEventmethod. This is for example necessary for ecommerce events like "view_item_list".
The native plugin implementation for iOS supports this already.

This PR is based on this already open, but outdated PR (#1458). I don't care which PR gets merged, but as this is blocking the usage of ecommerce events, this is really important for me.

Related Issues

This PR fixes:

• Fixes [firebase_analytics] handle nested json in event params #1036
• Fixes [firebase_analytics] List type paramters #2835
• Fixes 🐛 [firebase_analytics] Item relevant events do not sent the right properties #4123

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[lColinDl]

@googlebot I fixed it.

[muccy]

Sorry for the bump, but this seems critical to me and I was about to make a similar PR

[CameliaTripon]

When can we expect this to be merged? We really need this fix for our application

[russellwheatley]

Hey @lColinDl, it would be great if you could have add a test to confirm an array and map type works here for us to consider this. Something like:

await FirebaseAnalytics().logEvent(
      name: 'test_complex_data',
      parameters: <String, dynamic>{
        'items': []// complex types here
      },
    )

I wasn't able to log complex data types using your changes in my own preliminary investigation. It was an invalid type error from the native side.

[rrousselGit]

Agreed with Russell, we'll want tests.

I also believe we'll want iOS and web support too.

[lColinDl]

iOS worked out of the box and if I look at the code for web it should also work. It is just Android that was not working. I wrote the test for the change now in the same way as the existing tests. Hope its fine now. I'm not sure why it's not working for you @russellwheatley and what exactly you tested, but the implementation works for me for all enhanced ecommerce events that I had to implement by now. If there is a specific case that is not working, please specify it for me, so I can test and adjust the code.

[rrousselGit]

Could you add a test for maps inside maps?

[russellwheatley]

great stuff so far, @lColinDl 🎉 . I agree with @rrousselGit, we should probably test a nested map as well 👍

[lColinDl]

Adjusted the tests. Now there is an Array containing a Map containing a Map. Hope that is enough :)

[rrousselGit]

Thanks!

Could you also add a test for the throw IllegalArgumentException?

[lColinDl]

Done

[Salakar]

Just waiting on the below if possible then I think we're good to merge:

[Salakar]

Looks like there's a failing Web test, could you take a look please? Thanks?

failing test

[russellwheatley]

LGTM