Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): add ability to cancel all but latest workflow run #5637

Merged

Conversation

mikehardy
Copy link
Contributor

Description

Previously, only workflows older then the current workflow were canceled

In very deep queues this means the current instance may not even run until there are future
runs enqueued, and those will not run - and thus will not cancel - the current run, leaving
the queue in a clogged state

Now any time a run instance finally gets off the queue and runs it will check all runs -
including runs queued after the current one - and it will clear all non-current runs including
itself, hopefully unclogging the queue

styfle/cancel-workflow-action#62 is the upstream PR

In the process I removed the github_token as in current versions of the action it is optional, and the one that was specified here is now the default.

Related Issues

No related issue logged, but @Salakar and @rrousselGit mentioned it was hurting productivity and requested I take a look

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Previously, only workflows older then the current workflow were canceled

In very deep queues this means the current instance may not even run until there are future
runs enqueued, and those will not run - and thus will not cancel - the current run, leaving
the queue in a clogged state

Now any time a run instance finally gets off the queue and runs it will check all runs -
including runs queued after the current one - and it will clear all non-current runs including
itself, hopefully unclogging the queue

styfle/cancel-workflow-action#62
@Salakar Salakar merged commit de6d4bf into firebase:master Apr 1, 2021
@mikehardy mikehardy deleted the @mikehardy/cancel-previous-workflow branch April 1, 2021 20:35
@firebase firebase locked and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants