feat(*web): switch to latest v9 Firebase JS SDK (compat) #7215
Conversation
Salakar
changed the title
|
Current known issues:
|
russellwheatley
requested review from
Ehesp,
kroikie and
Salakar
as code owners
|
FYI the v9 SDKs do infact accept null, or should:
I can do some digging and see if it's an SDK issue. |
@Ehesp could it be the compat layer maybe? |
|
Visit the preview URL for this PR (updated for commit e54ef98): https://flutter-firebase-docs--pr7215-russell-web-compat-dve6v0sl.web.app (expires Thu, 28 Apr 2022 18:00:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Confirmed v9 SDK itself allows null to be set, will check the compat layer. |
|
And on 9.4.0 (& 9.3.0) compat it also works fine in the browser. Hmm. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
The errors come through with additional space/periods after the message too: |
|
Tried all sorts - cannot get |
# Conflicts: # docs/versions.js # packages/cloud_firestore/cloud_firestore/example/web/index.html # packages/cloud_functions/cloud_functions/example/web/index.html # packages/firebase_analytics/firebase_analytics/example/web/index.html # packages/firebase_app_check/firebase_app_check/example/web/index.html # packages/firebase_auth/firebase_auth/example/web/index.html # packages/firebase_core/firebase_core/example/web/index.html # packages/firebase_core/firebase_core_web/lib/src/firebase_sdk_version.dart # packages/firebase_database/firebase_database/example/web/index.html # packages/firebase_messaging/firebase_messaging/example/web/firebase-messaging-sw.js # packages/firebase_messaging/firebase_messaging/example/web/index.html # packages/firebase_performance/firebase_performance/example/web/index.html # packages/firebase_storage/firebase_storage/example/web/index.html
|
@russellwheatley @Ehesp - it looks like |
|
Still keeping this as blocked as latest compat versions do not appear to work. Firebase installations-compat script is non-existent. But the e2e tests simply hang as well which might be a result of no installations module. Not sure it's worth pursuing this if we're doing a rewrite of the webs side of things for web v9 integration. |
|
@russellwheatley Has a decision been made on whether to go forward with this upgrade or to wait for a web rewrite? Also, where can I follow along with that kind of discussion? An app in google would like to see this JS dep upgrade happen. |
|
Hey @ChristianEdwardPadilla, we have decided not to continue with making v9-web-compat since it has some incompatibilities, and instead will focus on refactoring the web implementation to integrate with the latest web v9. We've already started refactoring, and we'll be ramping up development from next week. |
Description
Explore the possibility of using web v9 compat SDKs.
Related Issues
closes #7041
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?