Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_analytics): upgrade analytics web to v9 sdk #8810

Merged
merged 5 commits into from Jun 28, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented May 31, 2022

Description

Analytics web v9 SDK.

This also includes a previously unsopported API: isSupported() to see if the browser supports Analytics.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…o v9/core

@russellwheatley
Copy link
Member Author

Hey @kolotum & @jorgeroncero, could you please ensure both of you have signed the CLA? We can't merge this PR until that is done. Thanks 👍

@jorgeroncero
Copy link
Contributor

@russellwheatley should be OK now. I changed my github username a few weeks ago and I didn't know I had to update it on the CLA.

@kolotum
Copy link
Contributor

kolotum commented Jun 27, 2022

I should have already signed the CLA. What is the comment to check this by myself?

@russellwheatley
Copy link
Member Author

@jorgeroncero Thanks, that has fixed the CLA check. No worries @kolotum, you have already signed it 👍.

@russellwheatley russellwheatley marked this pull request as ready for review June 28, 2022 11:48
@russellwheatley russellwheatley merged commit e0bff2f into v9/core Jun 28, 2022
@russellwheatley russellwheatley deleted the v9/analytics branch June 28, 2022 14:44
@firebase firebase locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: web Issues / PRs which are specifically for web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants