Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_app_check): upgrade app_check web to v9 sdk. #8816

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

russellwheatley
Copy link
Member

Description

See title.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…o v9/core

@Salakar Salakar added the platform: web Issues / PRs which are specifically for web. label Jun 1, 2022
@russellwheatley russellwheatley marked this pull request as ready for review June 28, 2022 15:34
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a wording suggestion but other than that LGTM

…e_app_check_web.dart

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
@russellwheatley russellwheatley merged commit de987a7 into v9/core Jun 30, 2022
@russellwheatley russellwheatley deleted the v9/app-check branch June 30, 2022 11:03
@firebase firebase locked and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: web Issues / PRs which are specifically for web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants