Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth, web): add phone mfa #9031

Merged
merged 8 commits into from
Jul 18, 2022
Merged

feat(auth, web): add phone mfa #9031

merged 8 commits into from
Jul 18, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jul 4, 2022

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Base automatically changed from feat/mfa-ios to feat/mfa July 6, 2022 13:39
@russellwheatley russellwheatley added plugin: auth platform: web Issues / PRs which are specifically for web. labels Jul 11, 2022
@Lyokone Lyokone marked this pull request as ready for review July 11, 2022 12:29
@Lyokone Lyokone requested a review from lesnitsky as a code owner July 12, 2022 07:24
@Lyokone Lyokone requested review from Salakar and russellwheatley and removed request for lesnitsky July 12, 2022 08:29
@Lyokone Lyokone merged commit bfd2695 into feat/mfa Jul 18, 2022
@Lyokone Lyokone deleted the feat/mfa-web branch July 18, 2022 08:50
Lyokone added a commit that referenced this pull request Jul 18, 2022
@Lyokone
feat(auth, web): add phone mfa (#9031)
244f5f4 
* feat(auth): add multifactoruser

* feat(auth, web): bridge

* feat(auth, web): solve bridging errors

* feat(auth, web): finish phone web mfa

* feat(auth, web): finish phone web mfa

* feat(auth, web): fix analyze

* feat(auth, web): fix analyze

* feat(auth, web): fix wrong argument
Lyokone added a commit that referenced this pull request Jul 18, 2022
@Lyokone
feat(auth, web): add phone mfa (#9031)
c6ddc18 
* feat(auth): add multifactoruser

* feat(auth, web): bridge

* feat(auth, web): solve bridging errors

* feat(auth, web): finish phone web mfa

* feat(auth, web): finish phone web mfa

* feat(auth, web): fix analyze

* feat(auth, web): fix analyze

* feat(auth, web): fix wrong argument
Lyokone added a commit that referenced this pull request Jul 20, 2022
@Lyokone @Salakar
feat(auth): add phone MFA (#9044)
1b85c8b 
* feat(auth, android): add phone MFA to Android (#8998)

* chores: update format CI step to match local melos format

* chores: update format CI step to match local melos format

* feat(auth, android): mfa

* feat(auth, android): add MFA to phone options

* feat(auth, android): add phone MFA

* feat(auth, android): add MFA signin

* feat(auth): add documentation

* feat(auth, android): fix typings

* feat(auth, android): fix tests

* feat(auth, android): add input for phone number to example app

* feat(auth, android): add unenroll and getEnrolledFactors

* feat(auth, android): fix formatting

* feat(auth, android): fix formatting

* feat(ui, android): use mocktail for mocking dependencies

* feat(auth, android): fix analyze

* feat(auth): fix melos generate command

* Update packages/firebase_auth/firebase_auth_platform_interface/lib/src/method_channel/method_channel_multi_factor.dart

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* feat(auth, ios): add phone MFA (#9008)

* chores: update format CI step to match local melos format

* chores: update format CI step to match local melos format

* feat(auth, android): mfa

* feat(auth, android): add MFA to phone options

* feat(auth, android): add phone MFA

* feat(auth, android): add MFA signin

* feat(auth, android): fix tests

* feat(auth, android): add input for phone number to example app

* feat(auth, android): add unenroll and getEnrolledFactors

* feat(auth, android): fix formatting

* feat(auth, android): fix formatting

* feat(auth, android): fix analyze

* feat(auth, ios): implement enroll

* feat(auth, ios): implement MFA for signin

* feat(auth, ios): add conditions to allow macos to build

* feat(auth, ios): add conditions to allow macos to build

* feat(auth, ios): fix ios build

* Update packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* fix: fix rebase

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* feat(auth): fix android merge

* feat(auth): fix ios merge

* test(auth): add MFA e2e (#9034)

* feat(auth, android): add phone MFA to Android (#8998)

* chores: update format CI step to match local melos format

* chores: update format CI step to match local melos format

* feat(auth, android): mfa

* feat(auth, android): add MFA to phone options

* feat(auth, android): add phone MFA

* feat(auth, android): add MFA signin

* feat(auth): add documentation

* feat(auth, android): fix typings

* feat(auth, android): fix tests

* feat(auth, android): add input for phone number to example app

* feat(auth, android): add unenroll and getEnrolledFactors

* feat(auth, android): fix formatting

* feat(auth, android): fix formatting

* feat(ui, android): use mocktail for mocking dependencies

* feat(auth, android): fix analyze

* feat(auth): fix melos generate command

* Update packages/firebase_auth/firebase_auth_platform_interface/lib/src/method_channel/method_channel_multi_factor.dart

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* feat(auth, ios): add phone MFA (#9008)

* chores: update format CI step to match local melos format

* chores: update format CI step to match local melos format

* feat(auth, android): mfa

* feat(auth, android): add MFA to phone options

* feat(auth, android): add phone MFA

* feat(auth, android): add MFA signin

* feat(auth, android): fix tests

* feat(auth, android): add input for phone number to example app

* feat(auth, android): add unenroll and getEnrolledFactors

* feat(auth, android): fix formatting

* feat(auth, android): fix formatting

* feat(auth, android): fix analyze

* feat(auth, ios): implement enroll

* feat(auth, ios): implement MFA for signin

* feat(auth, ios): add conditions to allow macos to build

* feat(auth, ios): add conditions to allow macos to build

* feat(auth, ios): fix ios build

* Update packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* fix: fix rebase

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* feat(auth): fix android merge

* feat(auth): fix ios merge

* feat(auth): add e2e tests

* fix(auth): fix reintroduce tests

* feat(auth): add documentation

* feat(auth): add e2e tests

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>

* feat(auth, web): add phone mfa (#9031)

* feat(auth): add multifactoruser

* feat(auth, web): bridge

* feat(auth, web): solve bridging errors

* feat(auth, web): finish phone web mfa

* feat(auth, web): finish phone web mfa

* feat(auth, web): fix analyze

* feat(auth, web): fix analyze

* feat(auth, web): fix wrong argument

* feat(auth, android): add early return

* feat(auth, android): change dynamic to Object

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
@firebase firebase locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ehesp Ehesp Ehesp approved these changes

@russellwheatley russellwheatley russellwheatley approved these changes

@Salakar Salakar Awaiting requested review from Salakar

Assignees
No one assigned
Labels
platform: web Issues / PRs which are specifically for web. plugin: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lyokone @Ehesp @russellwheatley