-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle button for Style Editor side panels doesn't work #451
Comments
Fixed by firebug/firebug.sdk@8b148af You need git pull from firebug.sdk repo. Honza |
Sorry to bother you, but what do you mean? How to do the What I have done so far: Initially
Today: (based on your instructions from here)
but after installing the produced xpi, the mentioned issue remains. I also tried today:
but the issue still remains with the produced xpi. |
Yeah, it's because I am not publishing Firebug.sdk after every commit. I am rather having linked the firebug.sdk directory using: npm link (just like you did for jpm above). So, git pull origin master from firebug.sdk directory is actually enough @darkred Does that make sense? Honza |
@janodvarko Yes, of course. |
@darkred
See more: To make sure that you setup that correctly check out the node_modules/frebug.sdk (in firebug.next dir) it should be slink not a dir. Does it help? Honza |
Yes, by unlinking+uninstalling both (and removing the directories), and then first And something more: I use Firefox nighly/inbounds exclusively, and as a javascript hobbyist it's great been able to watch the development of (and use) firebug.next each day, and contribute to it if I can. So I'd like to make this suggestion, please: |
Excellent!
Good point I'll do it. Honza |
Thank you. Also, I just installed Firebug 3 beta 2 in Nightly 45.0a1 x64 2015-11-20 in win10 x64(even on a clean profile), _Also, another thing I noticed is that, the latest xpi I built via `jpm xpi` was [1034 KB](https://www.dropbox.com/s/w17dcew82yovnjj/firebug%40software.joehewitt.com-3.0.0-beta.2.xpi?dl=0) while, the one for beta 2 is 801 KB. Why is that? Is this expected?_ |
Just for confirmation, it's also working for me now. Thank you, Honza! Sebastian |
@SebastianZ commented on Nov 23, 2015, 1:42 PM GMT+2:
I just tried installing it once more in Nightly 45.0a1 x64 2015-11-22 (win 10 x64) in a clean profile (with e10s enabled), and the toggle button is not working! Also, the button doesn't work after |
Right, it just works when running Sebastian |
@janodvarko A comment on this, please? |
Ah, both should be fixed now:
Honza |
Thank you |
The side panel toggle button doesn't work within the Style Editor panel.
![Side panels toggle button in Style Editor panel](https://cloud.githubusercontent.com/assets/958943/11235233/f674657c-8dcf-11e5-8f00-124db8c27062.png)
Sebastian
The text was updated successfully, but these errors were encountered: