optionally mark sent packet as rdpInspectorInternals #9
Conversation
|
|
||
| // NOTE: the following option asks firebug.sdk to mark custom actors registering RDP packets | ||
| // as rdpInspectorInternals (which helps to filter out them from the packet list) | ||
| if (options.rdpInspectorInternals) { |
There was a problem hiding this comment.
@janodvarko I'm not sure this is the best solution (because it is specific to the rdp-inspector and it sounds a bit out of scope inside the firebug.sdk).
I can turn this into a more generic options.customAttributes (which, if specified, will be merged into the json RDP packet), how it sounds to you?
There was a problem hiding this comment.
Yes, customAttributes sounds better.
Also, we could try to use "getTab" packets instead of "listTabs" when possible and keep backward compatibility (not sure when "getTab" has bee introduced). Can be a follow-up.
Honza
rpl
force-pushed
the
feature/help-filtering-rdpi-packets
branch
2 times, most recently
from
44b6369
to
23c4f1b
Compare
|
@janodvarko I've created the related change in the rdp-inspector as firebug/rdp-inspector#58, but that pull request travis-ci build should fail until we release this change on npm. how about releasing it as 0.6.0? |
rpl
force-pushed
the
feature/help-filtering-rdpi-packets
branch
from
23c4f1b
to
86a8ef5
Compare
|
@janodvarko I've just rebased this PR to the new master, once merged and released, I'm going to rebase and update the firebug/rdp-inspector#58 accordingly (with the updated the firebug.sdk dependency in the RDPi's package.json to the new version, e.g. 0.6.2) |
optionally mark sent packet as rdpInspectorInternals
|
Excellent Honza |
Changes needed by RDP Inspector to be able to filter out RDP packets needed by the tools itself (firebug/rdp-inspector#55), by optionally mark RDP packets used to register custom global / tab actors as
rdpInspectorInternals.