mark RDPi internals rdp packages using the customAttributes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom firebug.sdk 0.6.2
rpl
force-pushed
the
tweaks/firebug-sdk-issue-9
branch
from
2045998
to
71cf0e7
Compare
|
@janodvarko I've added to this PR a test case for the inspector-service, which tests the issue fixed in firebug/firebug.sdk#10 the build currently fails and the inspector-service test case produces the expected stack trace: and I've tested it on firebug.sdk master (where firebug/firebug.sdk#10 is already merged) to check all the jpm tests pass there: |
|
@janodvarko I've just pushed the updated this branch (with |
janodvarko
added a commit
that referenced
this pull request
Jul 16, 2015
mark RDPi internals rdp packages using the customAttributes
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the filtering using the feature implemented in firebug/firebug.sdk#9 (which should be included in a new firebug.sdk release, e.g. proposed as 0.6.0)