Avoid another NPE

firebug · May 11, 2012 · 1684cdb · 1684cdb · SebastianZ · May 14, 2012
1 parent 7706f47
commit 1684cdb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/extension/content/firebug/css/computedPanel.js b/extension/content/firebug/css/computedPanel.js
@@ -124,9 +124,18 @@ CSSComputedPanel.prototype = Obj.extend(Firebug.Panel,
             var href = selector.href;
             var line = selector.ruleLine;
             var rule = selector.selector._cssRule._domRule;
+
+            if (!rule.parentStyleSheet)
+            {
+                FBTrace.sysout("computedPanel.getSourceLink; no parent Stylesheet! " +
+                    "ERROR FIX ME");
+                return null;
+            }
+
             var instance = Css.getInstanceForStyleSheet(rule.parentStyleSheet);
+            var sourceLink = line != -1 ? new SourceLink.SourceLink(href, line, "css",
+                rule, instance) : null;
 
-            var sourceLink = line != -1 ? new SourceLink.SourceLink(href, line, "css", rule, instance) : null;
             return sourceLink;
         }
     }),

diff --git a/extension/content/firebug/css/cssPanel.js b/extension/content/firebug/css/cssPanel.js
@@ -448,7 +448,7 @@ Firebug.CSSStyleSheetPanel.prototype = Obj.extend(Firebug.Panel,
                         if (FBTrace.DBG_ERRORS && FBTrace.DBG_CSS)
                         {
                             FBTrace.sysout("cssPanel.getStyleSheetRules; Missing Namespace! " +
-                                "FIX ME", rule);
+                                "ERROR FIX ME", rule);
                         }
                     }
                 }