Issue 6316: Improve usability of long (and wide) stack traces

firebug · Mar 27, 2013 · 50240f1 · 50240f1
1 parent 68f4214
commit 50240f1
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 14 deletions.
diff --git a/extension/content/firebug/debugger/stack/callstackPanel.js b/extension/content/firebug/debugger/stack/callstackPanel.js
@@ -14,9 +14,10 @@ define([
     "firebug/chrome/menu",
     "firebug/debugger/stack/stackFrameRep",
     "firebug/debugger/stack/stackTrace",
+    "firebug/lib/options",
 ],
 function(Obj, Firebug, FBTrace, FirebugReps, Events, Wrapper, StackFrame, Css, Arr, Dom, Menu,
-    StackFrameRep, StackTrace) {
+    StackFrameRep, StackTrace, Options) {
 
 // ********************************************************************************************* //
 // Constants
@@ -209,6 +210,10 @@ CallstackPanel.prototype = Obj.extend(Firebug.Panel,
 
         Css.setClass(this.panelNode, "objectBox-stackTrace");
 
+        // Update visibility of stack frame arguments.
+        var name = "showStackFrameArguments";
+        this.updateOption(name, Options.get(name));
+
         if (trace && trace.frames.length != 0)
         {
             var rep = Firebug.getRep(trace, this.context);
@@ -261,9 +266,9 @@ CallstackPanel.prototype = Obj.extend(Firebug.Panel,
             "callstack.option.tip.Omit_Object_Path_Stack"));
 
         // Show/hide stack frame arguments.
-        items.push(Menu.optionMenu("callstack.option.Hide_Arguments",
+        items.push(Menu.optionMenu("callstack.option.Show_Arguments",
-            "hideStackFrameArguments",
+            "showStackFrameArguments",
-            "callstack.option.tip.Hide_Arguments"));
+            "callstack.option.tip.Show_Arguments"));
 
         return items;
     },
@@ -299,12 +304,12 @@ CallstackPanel.prototype = Obj.extend(Firebug.Panel,
 
     updateOption: function(name, value)
     {
-        if (name == "hideStackFrameArguments")
+        if (name == "showStackFrameArguments")
         {
             if (value)
-                Css.setClass(this.panelNode, "hideArguments");
-            else
                 Css.removeClass(this.panelNode, "hideArguments");
+            else
+                Css.setClass(this.panelNode, "hideArguments");
         }
     },
 });

diff --git a/extension/defaults/preferences/firebug.js b/extension/defaults/preferences/firebug.js
@@ -100,7 +100,7 @@ pref("extensions.firebug.breakOnExceptions", false);
 
 // Stack
 pref("extensions.firebug.omitObjectPathStack", false);
-pref("extensions.firebug.hideStackFrameArguments", false);
+pref("extensions.firebug.showStackFrameArguments", true);
 
 // DOM
 pref("extensions.firebug.showUserProps", true);

diff --git a/extension/locale/en-US/firebug.properties b/extension/locale/en-US/firebug.properties
@@ -983,11 +983,11 @@ OmitObjectPathStack=Omit Toolbar Stack
 callstack.option.tip.Omit_Object_Path_Stack=Do not display the object path stack
 Load_Original_Source=Load Original Source
 css.tip.Load_Original_Source=Discard the changes and load the original CSS
-# LOCALIZATION NOTE (callstack.option.Hide_Arguments, callstack.option.tip.Hide_Arguments):
+# LOCALIZATION NOTE (callstack.option.Show_Arguments, callstack.option.tip.Show_Arguments):
 # Stack side panel option (located in tab's option menu). If set to true,
-# function arguments are not displayed
+# function arguments are displayed
-callstack.option.Hide_Arguments=Hide Arguments
+callstack.option.Show_Arguments=Show Arguments
-callstack.option.tip.Hide_Arguments=Do not display function arguments
+callstack.option.tip.Show_Arguments=Display also function arguments
 # LOCALIZATION NOTE (Copy_Rule_Declaration, css.tip.Copy_Rule_Declaration):
 # Menu item label and tooltip used in CSS panel/Style side panel context menu.
 # Allows copying the current CSS rule including all its properties to the clipboard.

diff --git a/extension/skin/classic/callstack.css b/extension/skin/classic/callstack.css
@@ -62,10 +62,10 @@
 }
 
 /**
- * The one-line list of arguments is hidden if the frame is exapanded. So, the source
+ * The one-line list of arguments is hidden if the frame is expanded. So, the source
  * link is nicely visible.
  * There is also an option that allows to hide the argument list by default
- * (see extensions.firebug.hideStackFrameArguments).
+ * (see extensions.firebug.showStackFrameArguments).
  */
 .objectBox-stackFrame.opened .arguments,
 .panelNode-callstack.hideArguments .objectBox-stackFrame .arguments {