Skip to content

Commit

Permalink
Replaced Windows twisties by SVG equivalents
Browse files Browse the repository at this point in the history
  • Loading branch information
SebastianZ committed May 6, 2013
1 parent 7ba1491 commit 5777dfa
Show file tree
Hide file tree
Showing 22 changed files with 674 additions and 22 deletions.
4 changes: 2 additions & 2 deletions extension/skin/classic/win/panel.css
Expand Up @@ -17,7 +17,7 @@
.breakpointHeader > .twisty,
.computedStyle.hasSelectors > .stylePropName,
.cookieRow > .cookieNameCol > .cookieNameLabel {
background-image: url(chrome://firebug/skin/win/twistyClosed.png);
background-image: url(chrome://firebug/skin/win/twistyClosed.svg);
background-repeat: no-repeat;
background-position: 2px calc(0.5em - 3px);
min-height: 12px;
Expand All @@ -38,7 +38,7 @@
.breakpointBlock.opened > .breakpointHeader > .twisty,
.computedStyle.hasSelectors.opened > .stylePropName,
.cookieRow.opened > .cookieNameCol > .cookieNameLabel {
background-image: url(chrome://firebug/skin/win/twistyOpen.png);
background-image: url(chrome://firebug/skin/win/twistyOpen.svg);
}

.hasHeaders .netHrefLabel,
Expand Down
Binary file removed extension/skin/classic/win/twistyClosed.png
Binary file not shown.
80 changes: 80 additions & 0 deletions extension/skin/classic/win/twistyClosed.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed extension/skin/classic/win/twistyOpen.png
Binary file not shown.
83 changes: 83 additions & 0 deletions extension/skin/classic/win/twistyOpen.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions tests/FBTest/skin/classic/testList.css
Expand Up @@ -47,11 +47,11 @@
}

.testListRow.results .testName {
background-image: url(chrome://fbtest/skin/twistyClosed.png);
background-image: url(chrome://fbtest/skin/twistyClosed.svg);
}

.testListRow.opened .testName {
background-image: url(chrome://fbtest/skin/twistyOpen.png);
background-image: url(chrome://fbtest/skin/twistyOpen.svg);
}

.testListRow.error .testLink {
Expand Down Expand Up @@ -164,11 +164,11 @@
}

.opened > .testGroupCol > .testGroupName {
background-image: url(chrome://fbtest/skin/twistyOpen.png);
background-image: url(chrome://fbtest/skin/twistyOpen.svg);
}

.testGroupName {
background-image: url(chrome://fbtest/skin/twistyClosed.png);
background-image: url(chrome://fbtest/skin/twistyClosed.svg);
background-repeat: no-repeat;
background-position: 2px 1px;
padding-left: 18px;
Expand Down
6 changes: 3 additions & 3 deletions tests/FBTest/skin/classic/testResult.css
Expand Up @@ -29,11 +29,11 @@
}

.opened > .testResultCol > .testResultMessage {
background-image: url(chrome://fbtest/skin/twistyOpen.png);
background-image: url(chrome://fbtest/skin/twistyOpen.svg);
}

.testResultMessage {
background-image: url(chrome://fbtest/skin/twistyClosed.png);
background-image: url(chrome://fbtest/skin/twistyClosed.svg);
background-repeat: no-repeat;
background-position: 2px 2px;
padding-left: 18px;
Expand Down Expand Up @@ -70,7 +70,7 @@
background: #EFEFEF;
padding-left: 18px;
position: absolute;
background-image: url(chrome://fbtest/skin/twistyClosed.png);
background-image: url(chrome://fbtest/skin/twistyClosed.svg);
background-repeat: no-repeat;
background-position: 2px 2px;
}
Expand Down
Binary file removed tests/FBTest/skin/classic/twistyClosed.png
Binary file not shown.
80 changes: 80 additions & 0 deletions tests/FBTest/skin/classic/twistyClosed.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed tests/FBTest/skin/classic/twistyOpen.png
Binary file not shown.
83 changes: 83 additions & 0 deletions tests/FBTest/skin/classic/twistyOpen.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

2 comments on commit 5777dfa

@staabm
Copy link

@staabm staabm commented on 5777dfa May 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianZ great to see that SVG Icons make there way into Firebug! 👏

@SebastianZ
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm slowly replacing the PNGs by SVGs also in preparation for making the whole Firebug UI sizable (and not just the texts).

I just didn't find a good way yet to convert the Firebug icon to SVG. The original is available in EPS format. So if you know a tool, let me know.

Sebastian

Please sign in to comment.