Issue 5778 (Make activated Break On ... more obvious in panel tabs)

http://code.google.com/p/fbug/issues/detail?id=5778
firebug · May 6, 2013 · 7ba1491 · 7ba1491
1 parent e510034
commit 7ba1491
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/extension/content/firebug/firebug.css b/extension/content/firebug/firebug.css
@@ -350,17 +350,14 @@ panelTab > panelTabMenu .menuPopup:-moz-locale-dir(rtl) {
 }
 
 panelTab[breakOnNextArmed="true"] > .panelTab-text {
-    text-shadow: 1px 1px 2px darkGray, 0 0 1em orange, 0 0 0.2em orange !important;
-    /* animation: armedBlinking 0.8s ease-out infinite alternate; see issue 5618 */
+    animation: armedBlinking 0.8s steps(9, end) infinite alternate;
 }
 
-/* see issue 5618
 panelTab.highlighted {
     text-shadow: 1px 1px 2px darkGray, 0px 0px 1em orange, 0px 0px 0.2em orange !important;
     transition-property: text-shadow;
-    transition-duration: 0.8s;
+    transition-duration: 1.4s;
 }
-*/
 
 panelTab[aria-disabled='true'] {
     color: graytext !important;

diff --git a/extension/content/firebug/js/breakpoint.js b/extension/content/firebug/js/breakpoint.js
@@ -25,7 +25,7 @@ function(Obj, Firebug, Domplate, FirebugReps, Locale, Events, SourceLink,
 // ********************************************************************************************* //
 // Constants
 
-/* const animationDuration = 0.8; see issue 5618 */
+const animationDuration = 0.8;
 
 // ********************************************************************************************* //
 // Breakpoints
@@ -111,7 +111,6 @@ Firebug.Breakpoint = Obj.extend(Firebug.Module,
         Menu.createMenuItems(menuPopup, menuItems);
     },
 
-    /* see issue 5618
     toggleTabHighlighting: function(event)
     {
         // Don't continue if it's the wrong animation phase
@@ -131,7 +130,6 @@ Firebug.Breakpoint = Obj.extend(Firebug.Module,
         panel.context.delayedArmedTab.setAttribute("breakOnNextArmed", "true");
         delete panel.context.delayedArmedTab;
     },
-    */
 
     updateBreakOnNextTooltips: function(panel)
     {
@@ -171,9 +169,6 @@ Firebug.Breakpoint = Obj.extend(Firebug.Module,
         var panelBar = Firebug.chrome.$("fbPanelBar1");
         var tab = panelBar.getTab(panel.name);
         if (tab)
-            tab.setAttribute("breakOnNextArmed", armed ? "true" : "false");
-
-        /* see issue 5618
         {
             if (armed)
             {
@@ -202,7 +197,6 @@ Firebug.Breakpoint = Obj.extend(Firebug.Module,
                 tab.setAttribute("breakOnNextArmed", "false");
             }
         }
-        */
     },
 
     updatePanelTabs: function(context)