Skip to content

Commit

Permalink
[1.10] Move external editors logic under "firebug/firefox" folder. Th…
Browse files Browse the repository at this point in the history
…is folder should be all about XUL and overlays. The "firebug/editor" folder should be all about Firebug inline editors.

http://code.google.com/p/fbug/source/detail?r=12762
  • Loading branch information
janodvarko committed Jan 25, 2012
1 parent 14e44da commit 800e7c5
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 9 deletions.
2 changes: 1 addition & 1 deletion extension/chrome.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ locale firebug zh-TW locale/zh-TW/

#overlay chrome://browser/content/browser.xul chrome://firebug/content/browserOverlay.xul
#overlay chrome://browser/content/browser.xul chrome://firebug/content/firefox/browserOverlayWithFrame.xul
#overlay chrome://browser/content/browser.xul chrome://firebug/content/editor/external/editorsBrowserOverlay.xul
#overlay chrome://browser/content/browser.xul chrome://firebug/content/firefox/external-editors/editorsBrowserOverlay.xul

#overlay chrome://global/content/customizeToolbar.xul chrome://firebug/content/firefox/start-button/customizeToolbarOverlay.xul
#overlay chrome://mozapps/content/extensions/about.xul chrome://firebug/content/firefox/aboutOverlay.xul
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
class="fbInternational">

<script type="application/x-javascript" src="chrome://firebug/content/trace.js"/>
<script type="application/x-javascript" src="chrome://firebug/content/editor/external/changeeditor.js"/>
<script type="application/x-javascript"
src="chrome://firebug/content/firefox/external-editors/changeeditor.js"/>

<vbox flex="1">
<hbox align="center">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ var gEditorManager =
item: item,
FBL: this._FBL
};
openDialog("chrome://firebug/content/editor/external/changeeditor.xul", "_blank", "modal,centerscreen,resizable", args, result);

openDialog("chrome://firebug/content/firefox/external-editors/changeeditor.xul",
"_blank", "modal,centerscreen,resizable", args, result);

if (result.saveChanges)
{
item.id = item.label.replace(/\W/g, "_");
Expand Down Expand Up @@ -167,7 +170,10 @@ var gEditorManager =
FBL: this._FBL
};
var result = {};
openDialog("chrome://firebug/content/editor/external/changeeditor.xul", "_blank", "modal,centerscreen", args, result);

openDialog("chrome://firebug/content/firefox/external-editors/changeeditor.xul",
"_blank", "modal,centerscreen", args, result);

if (result.saveChanges)
{
this._saveItem(item);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
persist="screenX screenY width height">

<script type="application/x-javascript" src="chrome://firebug/content/xpcom.js"/>
<script type="application/x-javascript" src="chrome://firebug/content/editor/external/editors.js"/>
<script type="application/x-javascript"
src="chrome://firebug/content/firefox/external-editors/editors.js"/>

<vbox flex="1" class="contentPane">
<label id="actionsIntro" control="editorsList"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

<overlay xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

<script type="application/x-javascript" src="chrome://firebug/content/editor/external/editorToContextMenu.js"/>
<script type="application/x-javascript"
src="chrome://firebug/content/firefox/external-editors/editorToContextMenu.js"/>

<!-- Basic editing related commands -->
<commandset id="mainCommandSet">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ Firebug.ExternalEditors = Obj.extend(Firebug.Module,
};

Firefox.openWindow("Firebug:ExternalEditors",
"chrome://firebug/content/editor/external/editors.xul",
"chrome://firebug/content/firefox/external-editors/editors.xul",
"", args);
},

Expand Down
2 changes: 1 addition & 1 deletion extension/content/firebug/firefox/firebugMenuOverlay.xul
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<!-- See license.txt for terms of usage -->

<?xul-overlay href="chrome://firebug/content/editor/external/editorsOverlay.xul"?>
<?xul-overlay href="chrome://firebug/content/firefox/external-editors/editorsOverlay.xul"?>

<overlay xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
xmlns:html="http://www.w3.org/1999/xhtml">
Expand Down
2 changes: 1 addition & 1 deletion extension/content/firebug/moduleConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Firebug.getModuleLoaderConfig = function(baseConfig)
"firebug/js/sourceFile",
"firebug/chrome/shortcuts",
"firebug/firefox/start-button/startButtonOverlay",
"firebug/editor/external/externalEditors",
"firebug/firefox/external-editors/externalEditors",
"firebug/firefox/firebugMenu",
"firebug/chrome/panelActivation",
"firebug/console/memoryProfiler",
Expand Down

0 comments on commit 800e7c5

Please sign in to comment.