some minor modifications for include() (issue6056)

[fflorent]

Takes into account Honza's remarks: http://code.google.com/p/fbug/issues/detail?id=6056#c30

I took the freedom to add others changes:

• the return statement for commandLineInclude.js is now CommandLineInclude, that has more chance to be useful than CommandLineRep. Moreover, CommandLineRep can be shared if we store it in FirebugReps
• in firebug.properties, I adapted commandline.include.loadFail
• for commandline.include.wrongAliasArgument, the message is "Wrong alias name", that implicitly asks for a non-empty string.

Don't hesitate to tell me if you are OK with them or not.

Thanks Honza

Florent

[simonlindholm]

Not that it matters much, but I'm not sure I like this change. include("test", 1) doesn't as much have a "wrong name" as much as it doesn't have one at all (it has an integer). So I like the original better (maybe with "expected non-empty string" if it matters, and I'm not sure it does). Also, s/wrong/invalid; "wrong" makes me think in the direction of "you guessed the wrong password".

[fflorent]

Also, s/wrong/invalid

Good point. I change that (for WrongUrlArgument too).

include("test", 1) doesn't as much have a "wrong name" as much as it doesn't have one at all (it has an integer)

So why not: "Invalid second argument; expected alias name" ?

[simonlindholm]

Works for me.

[janodvarko]

the return statement for commandLineInclude.js is now CommandLineInclude, that has more chance
to be useful than CommandLineRep.

Agree, I usually do the same. Modules should be the shared communication point.

Honza