Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Black does not format files inside integration_tests/build #3166

Closed
dianpopa opened this issue Oct 6, 2022 · 0 comments · Fixed by #3292
Closed

[Bug] Black does not format files inside integration_tests/build #3166

dianpopa opened this issue Oct 6, 2022 · 0 comments · Fixed by #3292
Labels
Good first issue Indicates a good issue for first-time contributors Type: Bug Indicates an unexpected problem or unintended behavior

Comments

@dianpopa
Copy link
Contributor

dianpopa commented Oct 6, 2022 •
edited

Describe the bug

See this psf/black#1193.

To Reproduce

./tools/devtool shell -p
cd tests/integration_tests/build
black .

No Python files are present to be formatted. Nothing to do

Expected behaviour

Files in integration_tests/build directory are Python formatted.
@dianpopa dianpopa added Type: Bug Indicates an unexpected problem or unintended behavior Good first issue Indicates a good issue for first-time contributors labels Oct 6, 2022
cm-iwata added a commit to cm-iwata/firecracker that referenced this issue Nov 26, 2022
@cm-iwata
fix(ci): add black config
901a4a8 
fix firecracker-microvm#3166
By default black exclude `build` directory.
We can override default config via pyproject.toml.

See https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
@cm-iwata cm-iwata mentioned this issue Nov 26, 2022
Merged
9 tasks
cm-iwata added a commit to cm-iwata/firecracker that referenced this issue Nov 26, 2022
@cm-iwata
fix(ci): add black config
b2bfeff 
fix firecracker-microvm#3166
By default black exclude `build` directory.
We can override default config via pyproject.toml.

See https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
cm-iwata added a commit to cm-iwata/firecracker that referenced this issue Nov 26, 2022
@cm-iwata
fix(ci): add black config
f1b12e3 
fix firecracker-microvm#3166
By default black exclude `build` directory.
We can override default config via pyproject.toml.

[1]: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
cm-iwata added a commit to cm-iwata/firecracker that referenced this issue Dec 2, 2022
@cm-iwata
fix(ci): add black config
a89fee6 
fix firecracker-microvm#3166
By default black exclude `build` directory.
We can override default config via pyproject.toml.

[1]: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
@pb8o pb8o closed this as completed in #3292 Dec 2, 2022
pb8o pushed a commit that referenced this issue Dec 2, 2022
@cm-iwata @pb8o
fix(ci): add black config
646cd02 
fix #3166
By default black exclude `build` directory.
We can override default config via pyproject.toml.

[1]: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Indicates a good issue for first-time contributors Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

format files by black inside integration_tests/build cm-iwata/firecracker
1 participant
@dianpopa