format files by black inside integration_tests/build #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-iwata
commented
Nov 26, 2022
roypat
reviewed
Nov 30, 2022
9 tasks
roypat
previously approved these changes
Dec 2, 2022
|
Looks good to me now! Could you squash your commits into one? |
fix firecracker-microvm#3166 By default black exclude `build` directory. We can override default config via pyproject.toml. [1]: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
|
@roypat |
roypat
approved these changes
Dec 2, 2022
pb8o
approved these changes
Dec 2, 2022
|
Thank you for the contribution @cm-iwata ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Specify black configration for check
tests/integration_tests/builddirectory.And also move
pyproject.tomlto project root.Because black can't find conf file in
tools/devctr/directory.Reason
Fixes #3166
By default black exclude
builddirectory.https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#command-line-options
We can override default config via pyproject.toml.
https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s).unsafecode is documented.CHANGELOG.md.rust-vmm.