-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format files by black inside integration_tests/build #3292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
good catch noticing that the build tests weren't being formatted! And thanks for directly submitting a fix. I only left a small comment (which is mostly to me being unfamiliar with python tooling), but overall looks pretty good to me!
Looks good to me now! Could you squash your commits into one? |
fix firecracker-microvm#3166 By default black exclude `build` directory. We can override default config via pyproject.toml. [1]: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
@roypat |
Thank you for the contribution @cm-iwata ! |
Changes
Specify black configration for check
tests/integration_tests/build
directory.And also move
pyproject.toml
to project root.Because black can't find conf file in
tools/devctr/
directory.Reason
Fixes #3166
By default black exclude
build
directory.https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#command-line-options
We can override default config via pyproject.toml.
https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s
).unsafe
code is documented.CHANGELOG.md
.rust-vmm
.