Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependabot configuration #3585

Merged
merged 4 commits into from
May 11, 2023
Merged

Add dependabot configuration #3585

merged 4 commits into from
May 11, 2023

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Mar 31, 2023

Changes

Adds a dependabot configuration file to make dependabot notify us of new dependency versions becoming available. Also make dependabot tag its PRs with Status: Awaiting Review so that our webhook gets executed.

Reason

Automating dependency management

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@roypat roypat marked this pull request as ready for review March 31, 2023 09:57
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 31, 2023
bchalios
bchalios previously approved these changes Mar 31, 2023
View reviewed changes
@roypat
Add dependabot configuration
c0810b9 
Adds a dependabot configuration file that
- checks for outdated dependencies daily
- Tags its commits with "Status: Awaiting Review"

Dependabot will also automatically pick up the Cargo.lock files in the
crates that we have in the tests directory.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@JonathanWoollett-Light JonathanWoollett-Light added the Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled label Apr 25, 2023
roypat added a commit to roypat/firecracker that referenced this pull request Apr 26, 2023
@roypat
test: Replace test_num_dependencies with github action
e3d1efc 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 26, 2023
@roypat
test: Replace test_num_dependencies with github action
d22f29b 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 26, 2023
@roypat
test: Replace test_num_dependencies with github action
491907c 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 26, 2023
@roypat
test: Replace test_num_dependencies with github action
e39b895 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 26, 2023
@roypat
test: Replace test_num_dependencies with github action
f9abd3d 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 26, 2023
@roypat
test: Replace test_num_dependencies with github action
0fef38f 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
0cc7333 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
4a42b6a 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
0b8ff24 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
ba24437 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
27bda73 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
12b5c70 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request Apr 27, 2023
@roypat
test: Replace test_num_dependencies with github action
ec0d329 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request May 2, 2023
@roypat
test: Replace test_num_dependencies with github action
4d18868 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this pull request May 2, 2023
@roypat
test: Replace test_num_dependencies with github action
11474db 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit that referenced this pull request May 11, 2023
@roypat
test: Replace test_num_dependencies with github action
2b2d5cd 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat merged commit 7d35066 into firecracker-microvm:main May 11, 2023
3 checks passed
sladyn98 pushed a commit to sladyn98/firecracker that referenced this pull request Jun 19, 2023
@roypat @sladyn98
test: Replace test_num_dependencies with github action
c530f41 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
ShadowCurse pushed a commit to ShadowCurse/firecracker that referenced this pull request Jul 26, 2023
@roypat @ShadowCurse
test: Replace test_num_dependencies with github action
cf5826f 
The purpose of the test_num_dependencies test was to be a "prompt" about
dependency changes in PRs. However, manually updating the
dependencies.txt file is incompatible with letting dependabot manage
automated dependency updates (firecracker-microvm#3585). We therefore decided to replace
the test with a different "prompt" in the form of an optional GitHub
Actions check that fails whenever a lockfile is touched.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanWoollett-Light JonathanWoollett-Light JonathanWoollett-Light approved these changes

@zulinx86 zulinx86 zulinx86 approved these changes

@bchalios bchalios bchalios left review comments

Assignees
No one assigned
Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roypat @JonathanWoollett-Light @bchalios @zulinx86 @pb8o