forked from firecracker-microvm/firecracker
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Replace test_num_dependencies with github action
The purpose of the test_num_dependencies test was to be a "prompt" about dependency changes in PRs. However, manually updating the dependencies.txt file is incompatible with letting dependabot manage automated dependency updates (firecracker-microvm#3585). We therefore decided to replace the test with a different "prompt" in the form of an optional GitHub Actions check that fails whenever a lockfile is touched. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
- Loading branch information
Showing
3 changed files
with
18 additions
and
133 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: Check no dependencies were modified | ||
|
||
on: | ||
pull_request | ||
|
||
jobs: | ||
dependency_changed_check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: "Checkout repository" | ||
uses: actions/checkout@v3 | ||
with: | ||
ref: ${{ github.event.pull_request.head.sha }} | ||
|
||
- name: "Check Cargo.lock not in changeset" | ||
run: | | ||
git fetch origin | ||
git diff origin/$GITHUB_BASE_REF.. --name-only| ( ! grep "Cargo.lock") |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters