fix todo: log virtio address #3592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roypat @JonathanWoollett-Light I fixed this in a new PR because the old PR kind of got messy with the signing of commits |
JonathanWoollett-Light
added
Priority: Low
|
I think the commit titled should be reworded, I would suggest: |
|
@sladyn98 Could you please rebase and resolve merge conflicts. |
|
@JonathanWoollett-Light Yeah sorry completely forgot about this : ) |
sladyn98
force-pushed
the
fix-todo
branch
2 times, most recently
from
54d9917
to
63088fa
Compare
Signed-off-by: sladynnunes <snunes@usc.edu>
|
@JonathanWoollett-Light Changed commit name and resolved conflicts |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
==========================================
- Coverage 82.66% 82.66% -0.01%
==========================================
Files 221 221
Lines 28192 28191 -1
==========================================
- Hits 23306 23305 -1
Misses 4886 4886
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Hi @sladyn98 , This PR has still some style issue and not passing the PR. Are yous till interested in fix those issues and merge your changes? |
roypat
pushed a commit
to roypat/firecracker
that referenced
this pull request
May 8, 2024
Resolve a TODO for logging the address of a descriptor chain head if fetching it from guest memory fails. Closes firecracker-microvm#3592 Signed-off-by: Patrick Roy <roypat@amazon.co.uk> Co-Authored-By: sladynnunes <snunes@usc.edu>
roypat
pushed a commit
to roypat/firecracker
that referenced
this pull request
May 8, 2024
Resolve a TODO for logging the address of a descriptor chain head if fetching it from guest memory fails. Closes firecracker-microvm#3592 Co-Authored-By: sladynnunes <snunes@usc.edu> Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
Resolve a TODO for logging the address of a descriptor chain head if fetching it from guest memory fails. Closes firecracker-microvm#3592 Co-Authored-By: sladynnunes <snunes@usc.edu> Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
Resolve a TODO for logging the address of a descriptor chain head if fetching it from guest memory fails. Closes firecracker-microvm#3592 Co-Authored-By: sladynnunes <snunes@usc.edu> Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
Resolve a TODO for logging the address of a descriptor chain head if fetching it from guest memory fails. Closes firecracker-microvm#3592 Co-Authored-By: sladynnunes <snunes@usc.edu> Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves
TODO: log addresssee #3273.Reason
Resolves TODO.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.