Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve untracked TODOs #3273

Open
JonathanWoollett-Light opened this issue Nov 17, 2022 · 5 comments
Open

Resolve untracked TODOs #3273

JonathanWoollett-Light opened this issue Nov 17, 2022 · 5 comments
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Type: Fix Indicates a fix to existing code

Comments

@JonathanWoollett-Light
Copy link
Contributor

JonathanWoollett-Light commented Nov 17, 2022

There a large number of relatively simple TODO comments in the code base, most do not have their own issues. This issue exist to track these.

To contribute, submit a PR resolving any TODO comment which does not have a linked issue and link your PR to this issue by including text like:

Resolves TODO: auto-generate kvm related structures with PartialEq on see #3273.

@JonathanWoollett-Light JonathanWoollett-Light added Good first issue Indicates a good issue for first-time contributors Quality: Technical Debt labels Nov 17, 2022
@StonewallJohnson
Copy link

Hello, I am a student from UT Austin and my group and I were wondering I we could work on this issue as part of our class assignment?

@xmarcalx
Copy link
Contributor

Hi @StonewallJohnson ,

Thanks for your interest into Firecracker. Yes of course you can take this issue.
We are not sure about specifically your class assignment and any relevance with this issue but definitely feel free to take this issue (or maybe part of it) and contribute toward!

Feel free to break down the tasks according relevant and self contained changes so also the maintainer will be able to easily review them.

@JonathanWoollett-Light JonathanWoollett-Light added Type: Fix Indicates a fix to existing code Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` and removed Quality: Technical Debt labels Mar 24, 2023
@VictoriaMen2a
Copy link

Hi, I am in @StonewallJohnson 's group and would like to confirm that we are currently working on this issue!

@andr3wy
Copy link
Contributor

andr3wy commented Apr 3, 2024

Hi everyone,

We're a group at UT Austin and we're interested in picking this issue back up and finishing it.

@JonathanWoollett-Light
Copy link
Contributor Author

JonathanWoollett-Light commented Apr 8, 2024

HI @andr3wy the intention with this issue is to express there are various smaller tasks in TODOs within the code base, where each of these small tasks can be a separate small PR.

For example one of these TODOs is:

// TODO Use `#[derive(Debug)]` when a new release of
// [rust-timerfd](https://github.com/main--/rust-timerfd) is published that includes
// https://github.com/main--/rust-timerfd/pull/12.

this would be a PR that would update the rust-timerfd version and replace impl fmt::Debug for Balloon with #[derive(Debug)].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Type: Fix Indicates a fix to existing code
Projects
None yet
Development

No branches or pull requests

5 participants