test: stop CPU load monitoring at the end of a test #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see errors during teardown. It is then not clear if the CPU usage happened during the call phase of the test (which would be legit) or the teardown (which would be a false positive). Restrict the CPU load monitoring part to only the part of the test we are interested in. Also remove the CPU load monitoring from Microvm, since this is the only user and it fits better as a Context Manager. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
added
Priority: Medium
In the SignOff custom commit rule, use the original message to check if signoff exists, since the line may be ignored otherwise. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
zulinx86
approved these changes
Apr 20, 2023
kalyazin
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the CPU load monitoring from Microvm, since this is the only user and it fits better as a Context Manager.
Changes
...
Reason
The assert/error belongs during the test call phase, and not teardown.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.