fix: Update x86/6.1 MSR baselines with RFDS_NO
#4537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
=======================================
Coverage 82.02% 82.03%
=======================================
Files 253 253
Lines 31046 31048 +2
=======================================
+ Hits 25467 25469 +2
Misses 5579 5579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
Done, thanks! |
Since Amazon Linux commit amazonlinux/linux/b2e92ab17e440a97c716b701ecd897eebca11ac0, KVM passes through bit 27 of the `MSR_IA32_ARCH_CAPABILITIES` MSR (0x10A) to the guest, to let them know whether the processor they're running on is affected by RFDS. According to Intel, only Atom processors are affected [[1]], and accordingly, for all instances in our CI this bit is reported to be 1. Thus, update the baselines. [1]: https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/register-file-data-sampling.html Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Passthrough in T2CL template, set to 1 in T2S template. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
zulinx86
approved these changes
Apr 3, 2024
kalyazin
approved these changes
Apr 3, 2024
wearyzen
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since Amazon Linux commit
amazonlinux/linux@b2e92ab, KVM passes through bit 27 of the
MSR_IA32_ARCH_CAPABILITIESMSR (0x10A) to the guest, to let them know whether the processor they're running on is affected by RFDS. According to Intel, only Atom processors are affected [1], and accordingly, for all instances in our CI this bit is reported to be 1. Thus, update the baselines.Reason
integration_tests/functional/test_cpu_template_helper.py::test_guest_cpu_config_changefailing on x86/6.1License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.